Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

knot-dns: 3.4.4 -> 3.4.5 #390962

Merged
merged 1 commit into from
Mar 20, 2025
Merged

knot-dns: 3.4.4 -> 3.4.5 #390962

merged 1 commit into from
Mar 20, 2025

Conversation

r-ryantm
Copy link
Contributor

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/project/knot/versions.

meta.description for knot-dns is: Authoritative-only DNS server from .cz domain registry

meta.homepage for knot-dns is: https://knot-dns.cz

meta.changelog for knot-dns is: https://gitlab.nic.cz/knot/knot-dns/-/releases/v3.4.5

Updates performed
  • Version update
To inspect upstream changes
Impact

Checks done


  • built on NixOS

Caution

A test defined in passthru.tests did not pass.

  • found 3.4.5 with grep in /nix/store/0r3n129l7p1c8gwz5903sav5phnxgbjs-knot-dns-3.4.5-bin
  • found 3.4.5 in filename of file in /nix/store/0r3n129l7p1c8gwz5903sav5phnxgbjs-knot-dns-3.4.5-bin

Rebuild report (if merged into master) (click to expand)
6 total rebuild path(s)

6 package rebuild(s)

First fifty rebuilds by attrpath

knot-dns
knot-resolver
prometheus-knot-exporter
python312Packages.libknot
python313Packages.libknot
Instructions to test this update (click to expand)

Either download from the cache:

nix-store -r /nix/store/0r3n129l7p1c8gwz5903sav5phnxgbjs-knot-dns-3.4.5-bin \
  --option binary-caches 'https://cache.nixos.org/ https://nixpkgs-update-cache.nix-community.org/' \
  --option trusted-public-keys '
  nixpkgs-update-cache.nix-community.org-1:U8d6wiQecHUPJFSqHN9GSSmNkmdiFW7GW7WNAnHW0SM=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The nixpkgs-update cache is only trusted for this store-path realization.)
For the cached download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A knot-dns https://github.com/r-ryantm/nixpkgs/archive/8c23be07ee93256e7ca09c2e3373e9e0eec41c04.tar.gz

Or:

nix build github:r-ryantm/nixpkgs/8c23be07ee93256e7ca09c2e3373e9e0eec41c04#knot-dns

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/0r3n129l7p1c8gwz5903sav5phnxgbjs-knot-dns-3.4.5-bin
ls -la /nix/store/0r3n129l7p1c8gwz5903sav5phnxgbjs-knot-dns-3.4.5-bin/bin


Pre-merge build results

We have automatically built all packages that will get rebuilt due to
this change.

This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review


x86_64-linux

✅ 11 packages built:
  • knot-dns
  • knot-dns.bin
  • knot-dns.dev
  • knot-resolver
  • knot-resolver.dev
  • prometheus-knot-exporter
  • prometheus-knot-exporter.dist
  • python312Packages.libknot
  • python312Packages.libknot.dist
  • python313Packages.libknot
  • python313Packages.libknot.dist

Maintainer pings

cc @vcunat for testing.

Tip

As a maintainer, if your package is located under pkgs/by-name/*, you can comment @NixOS/nixpkgs-merge-bot merge to automatically merge this update using the nixpkgs-merge-bot.


Add a 👍 reaction to pull requests you find important.

Copy link
Member

@vcunat vcunat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if there's some kind of flakiness in knot-dns.tests.kea (see aarch64-linux CI) or possibly elsewhere. I built knot-dns.tests on x86_64 NixOS on this commit a few times (--rebuild) without any issue.

Either way, I see nothing worth blocking this PR.

@vcunat
Copy link
Member

vcunat commented Mar 19, 2025

Also checked knot-dns.tests on an aarch64-darwin, as that timed out in CI.

@vcunat vcunat merged commit 2b7d9e2 into NixOS:master Mar 20, 2025
27 checks passed
@vcunat vcunat added the backport release-24.11 Backport PR automatically label Mar 20, 2025
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Mar 20, 2025

Successfully created backport PR for release-24.11:

@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Mar 20, 2025

Git push to origin failed for release-24.11 with exitcode 1

@r-ryantm r-ryantm deleted the auto-update/knot-dns branch March 20, 2025 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants