Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pynac: remove #390974

Merged
merged 1 commit into from
Mar 18, 2025
Merged

pynac: remove #390974

merged 1 commit into from
Mar 18, 2025

Conversation

GaetanLepage
Copy link
Contributor

@GaetanLepage GaetanLepage commented Mar 18, 2025

Things done

The package is broken (see below) and has been archived in 2021: https://github.com/pynac/pynac.

inifcns_orthopoly.cpp: In function 'GiNaC::ex GiNaC::chebyt_eval(const ex&, const ex&)':
inifcns_orthopoly.cpp:59:9: error: 'fmpz_poly_init' was not declared in this scope; did you mean 'fmpq_poly_init'?
   59 |         fmpz_poly_init(p);
      |         ^~~~~~~~~~~~~~
      |         fmpq_poly_init
inifcns_orthopoly.cpp:60:9: error: 'fmpz_poly_chebyshev_t' was not declared in this scope
   60 |         fmpz_poly_chebyshev_t(p, static_cast<ulong>(numn.to_long()));
      |         ^~~~~~~~~~~~~~~~~~~~~
inifcns_orthopoly.cpp:61:19: error: 'fmpz_poly_length' was not declared in this scope; did you mean 'fmpq_poly_length'?
   61 |         int len = fmpz_poly_length(p);
      |                   ^~~~~~~~~~~~~~~~
      |                   fmpq_poly_length
inifcns_orthopoly.cpp:66:17: error: 'fmpz_poly_get_coeff_mpz' was not declared in this scope; did you mean 'fmpq_poly_get_coeff_fmpz'?
   66 |                 fmpz_poly_get_coeff_mpz(bigint, p, i);
      |                 ^~~~~~~~~~~~~~~~~~~~~~~
      |                 fmpq_poly_get_coeff_fmpz
inifcns_orthopoly.cpp:72:9: error: 'fmpz_poly_clear' was not declared in this scope; did you mean 'fmpq_poly_clear'?
   72 |         fmpz_poly_clear(p);
      |         ^~~~~~~~~~~~~~~
      |         fmpq_poly_clear
inifcns_orthopoly.cpp: In function 'GiNaC::ex GiNaC::chebyu_eval(const ex&, const ex&)':
inifcns_orthopoly.cpp:118:9: error: 'fmpz_poly_init' was not declared in this scope; did you mean 'fmpq_poly_init'?
  118 |         fmpz_poly_init(p);
      |         ^~~~~~~~~~~~~~
      |         fmpq_poly_init
inifcns_orthopoly.cpp:119:9: error: 'fmpz_poly_chebyshev_u' was not declared in this scope
  119 |         fmpz_poly_chebyshev_u(p, static_cast<ulong>(numn.to_long()));
      |         ^~~~~~~~~~~~~~~~~~~~~
inifcns_orthopoly.cpp:120:19: error: 'fmpz_poly_length' was not declared in this scope; did you mean 'fmpq_poly_length'?
  120 |         int len = fmpz_poly_length(p);
      |                   ^~~~~~~~~~~~~~~~
      |                   fmpq_poly_length
inifcns_orthopoly.cpp:125:17: error: 'fmpz_poly_get_coeff_mpz' was not declared in this scope; did you mean 'fmpq_poly_get_coeff_fmpz'?
  125 |                 fmpz_poly_get_coeff_mpz(bigint, p, i);
      |                 ^~~~~~~~~~~~~~~~~~~~~~~
      |                 fmpq_poly_get_coeff_fmpz
inifcns_orthopoly.cpp:131:9: error: 'fmpz_poly_clear' was not declared in this scope; did you mean 'fmpq_poly_clear'?
  131 |         fmpz_poly_clear(p);
      |         ^~~~~~~~~~~~~~~
      |         fmpq_poly_clear
At global scope:
cc1plus: note: unrecognized command-line option '-Wno-parentheses-equality' may have been intended to silence earlier diagnostics
make[2]: *** [Makefile:808: libpynac_la-inifcns_orthopoly.lo] Error 1
make[2]: Leaving directory '/build/source/ginac'
make[1]: *** [Makefile:496: all-recursive] Error 1
make[1]: Leaving directory '/build/source'
make: *** [Makefile:403: all] Error 2
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@GaetanLepage
Copy link
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 390974


x86_64-linux

⏩ 1 package marked as broken and skipped:
  • pynac

aarch64-linux

⏩ 1 package marked as broken and skipped:
  • pynac

x86_64-darwin

⏩ 1 package marked as broken and skipped:
  • pynac

aarch64-darwin

⏩ 1 package marked as broken and skipped:
  • pynac

@collares
Copy link
Member

Thanks! The Pynac repo (https://github.com/pynac/pynac) was archived three years ago. I'd be happy with just removing the package as well.

@GaetanLepage
Copy link
Contributor Author

Thanks! The Pynac repo (https://github.com/pynac/pynac) was archived three years ago. I'd be happy with just removing the package as well.

Fine by me!

@GaetanLepage GaetanLepage changed the title pynac: mark as broken pynac: remove Mar 18, 2025
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux and removed 10.rebuild-darwin: 1 10.rebuild-darwin: 1-10 10.rebuild-linux: 1 10.rebuild-linux: 1-10 labels Mar 18, 2025
@7c6f434c 7c6f434c merged commit b5b242a into NixOS:master Mar 18, 2025
56 of 59 checks passed
@GaetanLepage GaetanLepage deleted the pynac branch March 18, 2025 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants