Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

denemo: mark as broken #390976

Merged
merged 1 commit into from
Mar 18, 2025
Merged

denemo: mark as broken #390976

merged 1 commit into from
Mar 18, 2025

Conversation

GaetanLepage
Copy link
Contributor

Things done

sffile.c: In function 'ConvertIllegalChar':
sffile.c:38:10: error: implicit declaration of function 'isprint' [-Wimplicit-function-declaration]
   38 |     if (!isprint(*p) || *p == '{' || *p == '}')
      |          ^~~~~~~
sffile.c:28:1: note: include '<ctype.h>' or provide a declaration of 'isprint'
   27 | #include "sf_util.h"
  +++ |+#include <ctype.h>
   28 |
sffile.c: In function 'ParseSoundfont':
sffile.c:54:10: error: type defaults to 'int' in declaration of 'initialized' [-Wimplicit-int]
   54 |   static initialized = FALSE;
      |          ^~~~~~~~~~~
make[2]: *** [Makefile:563: libsffile_a-sffile.o] Error 1
make[2]: Leaving directory '/build/denemo-2.6.0/libs/libsffile'
make[1]: *** [Makefile:653: all-recursive] Error 1
make[1]: Leaving directory '/build/denemo-2.6.0'
make: *** [Makefile:562: all] Error 2

cc @olynch

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Mar 18, 2025
@GaetanLepage
Copy link
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 390976

@SuperSandro2000
Copy link
Member

Broken like that since months

@SuperSandro2000 SuperSandro2000 merged commit b56a9f7 into NixOS:master Mar 18, 2025
25 of 27 checks passed
@GaetanLepage GaetanLepage deleted the denemo branch March 18, 2025 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants