Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: fix nixos manual should rebuild on 'lib/**' changes #391020

Merged
merged 1 commit into from
Mar 18, 2025

Conversation

hsjobeki
Copy link
Contributor

Fix for the problem that caused: #391017

nixos-manual must also be rebuilt for changes in lib.

This is perhaps one of the best integration tests for evalModules, because it evaluates the complete zoo of 40k options.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@hsjobeki hsjobeki requested a review from Mic92 March 18, 2025 17:24
@github-actions github-actions bot added the 6.topic: continuous integration Affects continuous integration (CI) in Nixpkgs, including Ofborg and GitHub Actions label Mar 18, 2025
@hsjobeki hsjobeki requested a review from infinisil March 18, 2025 17:25
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Mar 18, 2025
@Mic92 Mic92 merged commit bc8560e into NixOS:master Mar 18, 2025
23 of 27 checks passed
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Mar 18, 2025

Git push to origin failed for release-24.11 with exitcode 1

@Mic92
Copy link
Member

Mic92 commented Mar 18, 2025

@hsjobeki could you open a backport PR for this change?

@hsjobeki hsjobeki added the backport staging-24.11 Backport PR automatically label Mar 18, 2025
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Mar 18, 2025

Git push to origin failed for staging-24.11 with exitcode 1

@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Mar 18, 2025

Git push to origin failed for release-24.11 with exitcode 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: continuous integration Affects continuous integration (CI) in Nixpkgs, including Ofborg and GitHub Actions 6.topic: policy discussion 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux backport release-24.11 Backport PR automatically
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants