Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python312Packages.manim: fix build #391025

Merged
merged 2 commits into from
Mar 19, 2025
Merged

Conversation

osbm
Copy link
Member

@osbm osbm commented Mar 18, 2025

Things done

Fixed the manim dependency issue.
Added "manim" as a mainProgram.
Added myself as a maintainer.

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@osbm osbm marked this pull request as ready for review March 18, 2025 17:42
@osbm osbm requested a review from GaetanLepage March 18, 2025 17:42
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Mar 18, 2025
@osbm
Copy link
Member Author

osbm commented Mar 18, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 391025


x86_64-linux

❌ 6 packages failed to build:
  • manim-slides
  • manim-slides.dist
  • python312Packages.manim-slides
  • python312Packages.manim-slides.dist
  • python313Packages.manim-slides
  • python313Packages.manim-slides.dist
✅ 4 packages built:
  • manim (python312Packages.manim)
  • manim.dist (python312Packages.manim.dist)
  • python313Packages.manim
  • python313Packages.manim.dist

@osbm
Copy link
Member Author

osbm commented Mar 18, 2025

@bpeetz

Hey i can also apply the same fix to the manim-slides package. Do you want me to add it to the PR?
I also realized simply removing the av dependency from the manim-slides derivation fixes the issue. (it gets the correct version of av from the manim package)

@nix-owners nix-owners bot requested a review from bpeetz March 19, 2025 01:24
@osbm
Copy link
Member Author

osbm commented Mar 19, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 391025


x86_64-linux

✅ 10 packages built:
  • manim (python312Packages.manim)
  • manim-slides
  • manim-slides.dist
  • manim.dist (python312Packages.manim.dist)
  • python312Packages.manim-slides
  • python312Packages.manim-slides.dist
  • python313Packages.manim
  • python313Packages.manim-slides
  • python313Packages.manim-slides.dist
  • python313Packages.manim.dist

@GaetanLepage
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 391025


x86_64-linux

✅ 10 packages built:
  • manim (python312Packages.manim)
  • manim-slides
  • manim-slides.dist
  • manim.dist (python312Packages.manim.dist)
  • python312Packages.manim-slides
  • python312Packages.manim-slides.dist
  • python313Packages.manim
  • python313Packages.manim-slides
  • python313Packages.manim-slides.dist
  • python313Packages.manim.dist

aarch64-linux

✅ 10 packages built:
  • manim (python312Packages.manim)
  • manim-slides
  • manim-slides.dist
  • manim.dist (python312Packages.manim.dist)
  • python312Packages.manim-slides
  • python312Packages.manim-slides.dist
  • python313Packages.manim
  • python313Packages.manim-slides
  • python313Packages.manim-slides.dist
  • python313Packages.manim.dist

Copy link
Contributor

@GaetanLepage GaetanLepage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@GaetanLepage GaetanLepage merged commit 453f999 into NixOS:master Mar 19, 2025
24 of 27 checks passed
@osbm osbm deleted the add-manim-mainProgram branch March 19, 2025 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: python 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants