Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/kanidm: add extraJsonFile to BindReadOnlyPaths if set #391044

Merged
merged 1 commit into from
Mar 23, 2025
Merged

nixos/kanidm: add extraJsonFile to BindReadOnlyPaths if set #391044

merged 1 commit into from
Mar 23, 2025
+1 −0

Conversation

oddlama
Copy link
Contributor

@oddlama oddlama commented Mar 18, 2025

This adds the extraJsonFile to BindReadOnlyPaths (if it is set) so that
kanidm may access the file if it resides outside of the nix store.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Mar 18, 2025
@oddlama oddlama requested a review from adamcstephens March 23, 2025 08:36
@adamcstephens adamcstephens merged commit 451d610 into NixOS:master Mar 23, 2025
28 checks passed
@oddlama oddlama deleted the fix/kanidm-bind-extrajsonfile branch March 23, 2025 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamcstephens adamcstephens

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oddlama @adamcstephens