Backport #386757 to release-24.11
#391063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 5387f9c)
(cherry picked from commit 25e851d)
The release management of deployer is something I've never seen. They basically commit the PHAR file in the source, in a specific branch. They also modify the runner `bin/dep` to use that PHAR. Therefore, this break on NixOS since we are using the PHAR. A workaround is to use the master branch that doesn't contain the PHAR. (cherry picked from commit 2e4faeb)
(cherry picked from commit 47f6b52)
(cherry picked from commit 874a6d7)
(cherry picked from commit 7e70611)
(cherry picked from commit e7304f5)
(cherry picked from commit 66d96a7)
(cherry picked from commit 6e8e6c4)
(cherry picked from commit 1de8208)
(cherry picked from commit 489ac48)
…t to `true` by default (cherry picked from commit 64b2466)
(cherry picked from commit c0999f4)
(cherry picked from commit 1afb093)
13 tasks
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.