Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nodePackages.ijavascript: drop #391067

Merged
merged 1 commit into from
Mar 21, 2025

Conversation

dotlambda
Copy link
Member

It fails to build with

npm error /nix/store/bhc0grw1nwzwgh55qapfqwb3vil5s49y-node-sources/deps/v8/include/v8-local-handle.h: In instantiation of 'v8::Local<T>::Local(v8::Local<S>) [with S = v8::Data; T = v8::Value]':
npm error ../../nan/nan_callbacks_12_inl.h:175:53:   required from here
npm error   175 |       cbinfo(info, obj->GetInternalField(kDataIndex));
npm error       |                                                     ^
npm error /nix/store/bhc0grw1nwzwgh55qapfqwb3vil5s49y-node-sources/deps/v8/include/v8-local-handle.h:269:42: error: static assertion failed: type check
npm error   269 |     static_assert(std::is_base_of<T, S>::value, "type check");
npm error       |                                          ^~~~~
npm error /nix/store/bhc0grw1nwzwgh55qapfqwb3vil5s49y-node-sources/deps/v8/include/v8-local-handle.h:269:42: note: 'std::integral_constant<bool, false>::value' evaluates to false

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

It fails to build with

    npm error /nix/store/bhc0grw1nwzwgh55qapfqwb3vil5s49y-node-sources/deps/v8/include/v8-local-handle.h: In instantiation of 'v8::Local<T>::Local(v8::Local<S>) [with S = v8::Data; T = v8::Value]':
    npm error ../../nan/nan_callbacks_12_inl.h:175:53:   required from here
    npm error   175 |       cbinfo(info, obj->GetInternalField(kDataIndex));
    npm error       |                                                     ^
    npm error /nix/store/bhc0grw1nwzwgh55qapfqwb3vil5s49y-node-sources/deps/v8/include/v8-local-handle.h:269:42: error: static assertion failed: type check
    npm error   269 |     static_assert(std::is_base_of<T, S>::value, "type check");
    npm error       |                                          ^~~~~
    npm error /nix/store/bhc0grw1nwzwgh55qapfqwb3vil5s49y-node-sources/deps/v8/include/v8-local-handle.h:269:42: note: 'std::integral_constant<bool, false>::value' evaluates to false
@github-actions github-actions bot added 6.topic: nodejs 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Mar 18, 2025
@dotlambda dotlambda merged commit a60f0c6 into NixOS:master Mar 21, 2025
27 checks passed
@dotlambda dotlambda deleted the nodePackages.ijavascript branch March 21, 2025 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nodejs 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant