Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport 390099 to release 24.11 #391074

Merged
merged 2 commits into from
Mar 19, 2025
Merged

Backport 390099 to release 24.11 #391074

merged 2 commits into from
Mar 19, 2025

Conversation

drupol
Copy link
Contributor

@drupol drupol commented Mar 18, 2025

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@JohnRTitor @drupol
buildNpmPackage: restructure with lib.extendMkDerivation
e82ac2e 
This allows using finalAttrs pattern.

(cherry picked from commit 70ae16e)
@JohnRTitor @drupol
buildNpmPackage: nixfmt
c34801c 
(cherry picked from commit e6ca2b6)
@nix-owners nix-owners bot requested a review from winterqt March 18, 2025 20:40
@drupol drupol mentioned this pull request Mar 18, 2025
Merged
7 tasks
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Mar 18, 2025
@drupol drupol mentioned this pull request Mar 19, 2025
Closed
@drupol drupol merged commit 29d9c00 into NixOS:release-24.11 Mar 19, 2025
28 checks passed
@drupol drupol deleted the backport-390099-to-release-24.11 branch March 19, 2025 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winterqt winterqt

Assignees
No one assigned
Labels
6.topic: nodejs 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@drupol @JohnRTitor