Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

closureInfo: write a doc comment #391079

Merged
merged 1 commit into from
Mar 18, 2025

Conversation

philiptaron
Copy link
Contributor

@philiptaron philiptaron commented Mar 18, 2025

To see it, run :doc (closureInfo.__functor closureInfo) in nix repl -f. on Nix before 2.256 and :doc closureInfo on Nix 2.26+.

This is how I discovered that :doc doesn't work on build helpers that are brought into the top level with callPackage.

This is also how I discovered that Nix 2.26 does the right thing and sees through that!

Things done

@philiptaron philiptaron requested a review from haylinmoore March 18, 2025 20:59
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Mar 18, 2025
To see it, run `:doc closureInfo `nix repl -f.` on Nix 2.26+.
@philiptaron philiptaron merged commit 9cf6930 into NixOS:master Mar 18, 2025
34 of 40 checks passed
@philiptaron philiptaron deleted the closure-info-docs branch March 18, 2025 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants