Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cosmic-greeter: 1.0.0-alpha.2 -> 1.0.0-alpha.6 #391093

Merged
merged 6 commits into from
Mar 23, 2025

Conversation

HeitorAugustoLN
Copy link
Member

@HeitorAugustoLN HeitorAugustoLN commented Mar 18, 2025

  • Updates cosmic-greeter from 1.0.0-alpha.2 to 1.0.0-alpha.6
  • Added myself as a package maintainer
  • Added a updateScript
  • Add X11 xkb rules paths to wrapper, because the default paths used by xkb-data crate are not compatible with Nix.
  • Use libcosmicAppHook
  • etc

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Set X11_BASE_RULES_XML and X11_BASE_EXTRA_RULES_XML environment variables
in the wrapper to fix xkeyboard_config path resolution. The xkb-data crate
used by cosmic-settings had hard-coded paths for the base.xml and extra.xml
files (/usr/share/X11/xkb/rules/), which are not compatible with NixOS.
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1 10.rebuild-linux: 1-10 labels Mar 18, 2025
@nix-owners nix-owners bot requested a review from nyabinary March 18, 2025 22:13
@HeitorAugustoLN
Copy link
Member Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 391093


x86_64-linux

✅ 1 package built:
  • cosmic-greeter

aarch64-linux

✅ 1 package built:
  • cosmic-greeter

@GaetanLepage
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 391093


x86_64-linux

✅ 1 package built:
  • cosmic-greeter

aarch64-linux

✅ 1 package built:
  • cosmic-greeter

@GaetanLepage GaetanLepage merged commit bbd4c4b into NixOS:master Mar 23, 2025
67 checks passed
@HeitorAugustoLN HeitorAugustoLN deleted the bump/cosmic-greeter branch March 23, 2025 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants