Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apptainer: 1.3.6 -> 1.4.0 #391099

Merged
merged 1 commit into from
Mar 19, 2025
Merged

Conversation

GaetanLepage
Copy link
Contributor

@GaetanLepage GaetanLepage commented Mar 18, 2025

Things done

Changelog: https://github.com/apptainer/apptainer/releases/tag/v1.4.0

cc @jbedo @ShamrockLee

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Mar 18, 2025
@nix-owners nix-owners bot requested review from jbedo and ShamrockLee March 18, 2025 22:29
@GaetanLepage
Copy link
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 391099


x86_64-linux

✅ 2 packages built:
  • apptainer
  • apptainer-overriden-nixos

aarch64-linux

✅ 2 packages built:
  • apptainer
  • apptainer-overriden-nixos

@GaetanLepage
Copy link
Contributor Author

apptainer.tests builds fine on both x86_64-linux and aarch64-linux.

Copy link
Contributor

@ShamrockLee ShamrockLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM considering existing functions still work.

Should we add something to the existing expression (in this PR or future ones) to support new features?

$ nix run github:NixOS/nixpkgs/refs/pull/391099/head#apptainer -- exec "$(nix build --no-link --print-out-paths -L github:NixOS/nixpkgs/refs/pull/391099/head#apptainer.tests.image-hello-cowsay)" hello
INFO:    gocryptfs not found, will not be able to use gocryptfs
WARNING: passwd file doesn't exist in container, not updating
WARNING: group file doesn't exist in container, not updating
Hello, world!

@GaetanLepage
Copy link
Contributor Author

LGTM considering existing functions still work.

Should we add something to the existing expression (in this PR or future ones) to support new features?

$ nix run github:NixOS/nixpkgs/refs/pull/391099/head#apptainer -- exec "$(nix build --no-link --print-out-paths -L github:NixOS/nixpkgs/refs/pull/391099/head#apptainer.tests.image-hello-cowsay)" hello
INFO:    gocryptfs not found, will not be able to use gocryptfs
WARNING: passwd file doesn't exist in container, not updating
WARNING: group file doesn't exist in container, not updating
Hello, world!

What features are you thinking about?

@SuperSandro2000 SuperSandro2000 merged commit 586549f into NixOS:master Mar 19, 2025
59 checks passed
@GaetanLepage GaetanLepage deleted the apptainer branch March 19, 2025 17:49
@ShamrockLee
Copy link
Contributor

What features are you thinking about?

E.g., the libsubuid mentioned in the changelog, and the gocryptfs mentioned in the message.

I have yet look into any of them, though.

@GaetanLepage
Copy link
Contributor Author

What features are you thinking about?

E.g., the libsubuid mentioned in the changelog, and the gocryptfs mentioned in the message.

I have yet look into any of them, though.

Oh right! Yes we can add those in follow-up PRs.
I might lack some time though. Feel free to ping me if you go ahead :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants