-
-
Notifications
You must be signed in to change notification settings - Fork 15.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
apptainer: 1.3.6 -> 1.4.0 #391099
apptainer: 1.3.6 -> 1.4.0 #391099
Conversation
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM considering existing functions still work.
Should we add something to the existing expression (in this PR or future ones) to support new features?
$ nix run github:NixOS/nixpkgs/refs/pull/391099/head#apptainer -- exec "$(nix build --no-link --print-out-paths -L github:NixOS/nixpkgs/refs/pull/391099/head#apptainer.tests.image-hello-cowsay)" hello
INFO: gocryptfs not found, will not be able to use gocryptfs
WARNING: passwd file doesn't exist in container, not updating
WARNING: group file doesn't exist in container, not updating
Hello, world!
What features are you thinking about? |
E.g., the I have yet look into any of them, though. |
Oh right! Yes we can add those in follow-up PRs. |
Things done
Changelog: https://github.com/apptainer/apptainer/releases/tag/v1.4.0
cc @jbedo @ShamrockLee
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.