Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rabbitmq-java-client: 3.3.4 -> 5.25.0, remove python2 dependency #391100

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

bengsparks
Copy link

@bengsparks bengsparks commented Mar 18, 2025

Removes yet another dependency on python2 from the tree.
Updates a nixos test that made use of a util program that is no longer being built.
As no further programs depend on rabbitmq-java-client, the jump of 2 major versions shouldn't be an issue.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@bengsparks
Copy link
Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 391100


x86_64-linux

✅ 1 package built:
  • rabbitmq-java-client

aarch64-linux

✅ 1 package built:
  • rabbitmq-java-client

x86_64-darwin

✅ 1 package built:
  • rabbitmq-java-client

aarch64-darwin

✅ 1 package built:
  • rabbitmq-java-client

@github-actions github-actions bot added the 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS label Mar 18, 2025
@bengsparks bengsparks force-pushed the rabbitmq-java-client-py2 branch 3 times, most recently from a3e8c63 to 385e119 Compare March 21, 2025 23:19
@bengsparks bengsparks force-pushed the rabbitmq-java-client-py2 branch 2 times, most recently from 20ae4c0 to 6bbfebf Compare March 22, 2025 23:51
@tomodachi94
Copy link
Member

Closes #169644

@bengsparks bengsparks force-pushed the rabbitmq-java-client-py2 branch 2 times, most recently from b0ad2c7 to ac1a5b5 Compare March 25, 2025 15:09
@bengsparks bengsparks force-pushed the rabbitmq-java-client-py2 branch from ac1a5b5 to d8c85de Compare March 25, 2025 15:17
@bengsparks bengsparks requested a review from tomodachi94 March 25, 2025 15:21
@bengsparks
Copy link
Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 391100


x86_64-linux

✅ 1 package built:
  • rabbitmq-java-client

aarch64-linux

✅ 1 package built:
  • rabbitmq-java-client

x86_64-darwin

✅ 1 package built:
  • rabbitmq-java-client

aarch64-darwin

✅ 1 package built:
  • rabbitmq-java-client

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants