Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport helix 25.01.1 to release 24.11 #391107

Merged

Conversation

mlen
Copy link

@mlen mlen commented Mar 18, 2025

Backports patches from #370713 and #375161 to release-24.11.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@NixOSInfra NixOSInfra added the 12. first-time contribution This PR is the author's first one; please be gentle! label Mar 18, 2025
@mlen
Copy link
Author

mlen commented Mar 18, 2025

@GaetanLepage: I think this is good to go. The automated backport failed, because there were 2 PRs that needed to be backported.

@GaetanLepage
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 391107


x86_64-linux

✅ 2 packages built:
  • evil-helix
  • helix

aarch64-linux

✅ 2 packages built:
  • evil-helix
  • helix

x86_64-darwin

✅ 2 packages built:
  • evil-helix
  • helix

aarch64-darwin

✅ 2 packages built:
  • evil-helix
  • helix

@GaetanLepage GaetanLepage merged commit 91fc691 into NixOS:release-24.11 Mar 18, 2025
25 of 29 checks passed
@mlen
Copy link
Author

mlen commented Mar 18, 2025

Thanks!

@mlen mlen deleted the backport-helix-to-release-24.11 branch March 18, 2025 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants