fish: fix aarch64-linux test failures #391150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamcstephens
changed the title
adamcstephens
force-pushed
the
push-smxtztmrqupr
branch
2 times, most recently
from
ca44308 to
9a2b863
Compare
adamcstephens
requested review from
r-vdp and
GaetanLepage
and removed request for
r-vdp
adamcstephens
changed the title
This comment was marked as outdated.
This comment was marked as outdated.
|
We could also try cherry-picking fish-shell/fish-shell@1d78c8b which seems like it may fix the issue. Do we have a quick way to reproduce the issue so that we can test if that commit fixes the issue? |
Yes, I’ll test the patch today. I got access to the nix-community build machine yesterday and was able to reproduce the failures there. Still not 100% failures but a few clean runs there will be a good sign. |
Parallel locale changes cause flaky tests on fast harder.
adamcstephens
force-pushed
the
push-smxtztmrqupr
branch
from
9a2b863 to
ca8f618
Compare
adamcstephens
changed the title
|
I just ran this three times without failure, so let's get it applied and keep an eye on the hydra builds. |
cole-h
approved these changes
Mar 19, 2025
GaetanLepage
approved these changes
Mar 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apply upstream fix.
Previously #389895
Closes #390901
Fixed #389377
Upstream fish-shell/fish-shell#11254
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.