Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

osmium-tool: 1.17.0 → 1.18.0 #391155

Merged
merged 1 commit into from
Mar 19, 2025
Merged

osmium-tool: 1.17.0 → 1.18.0 #391155

merged 1 commit into from
Mar 19, 2025

Conversation

das-g
Copy link
Member

@das-g das-g commented Mar 19, 2025

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@das-g
Copy link
Member Author

das-g commented Mar 19, 2025

@NixOS/nixpkgs-merge-bot merge

@nixpkgs-merge-bot
Copy link
Contributor

@das-g merge not permitted (#305350):
R-Ryantm Maintainer merge: pr author is not r-ryantm
CommitterPR: pr author is not committer

@wegank wegank added 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package 12.approvals: 2 This PR was reviewed and approved by two reputable people labels Mar 19, 2025
@sikmir
Copy link
Member

sikmir commented Mar 19, 2025

@das-g Consider replacing maintainers = lib.teams.geospatial.members ++ (with lib.maintainers; [ das-g ]); with maintainers = lib.teams.geospatial.members;, since you are in geospatial team anyway.

@das-g
Copy link
Member Author

das-g commented Mar 19, 2025

Consider replacing maintainers = lib.teams.geospatial.members ++ (with lib.maintainers; [ das-g ]); with maintainers = lib.teams.geospatial.members;, since you are in geospatial team anyway.

While I'm in @NixOS/geospatial, I'm (since PR #288118) not anymore in lib.teams.geospatial, as the latter caused me to get too many notifications about packages I know nothing about and don't have time for.

@sikmir
Copy link
Member

sikmir commented Mar 19, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 391155


x86_64-darwin

✅ 1 package built:
  • osmium-tool

@sikmir sikmir merged commit d99c546 into NixOS:master Mar 19, 2025
27 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12.approvals: 2 This PR was reviewed and approved by two reputable people 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants