Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

antlr4_13: fix Issue #379757 #391183

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hzeller
Copy link
Contributor

@hzeller hzeller commented Mar 19, 2025

Things done

Add patch to make cmake install script contain the correct path to the includes, fixing #379757

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@hzeller hzeller requested a review from katrinafyi March 19, 2025 05:26
@hzeller
Copy link
Contributor Author

hzeller commented Mar 19, 2025

@katrinafyi does this fix the issue #379757 for you ?

Copy link
Member

@katrinafyi katrinafyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for doing this! it seems to work for me.

pr looks good aside from the commit message, can you rebase and change it to say specifically what it does?

something like "antlr4_13: add patch to fix libantlrcpp_INCLUDE_INSTALL_DIR"

@hzeller hzeller force-pushed the feature-20250318-fix-379757 branch from 5d3bbee to 486f01c Compare March 19, 2025 05:56
@hzeller
Copy link
Contributor Author

hzeller commented Mar 19, 2025

Done, updated commit message.

Copy link
Member

@katrinafyi katrinafyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Mar 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants