Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.wxpython: drop SDL dependency #391240

Merged
merged 1 commit into from
Mar 19, 2025

Conversation

LordGrimmauld
Copy link
Contributor

@LordGrimmauld LordGrimmauld commented Mar 19, 2025

this dependency was unused:

$ nix why-depends .#python313Packages.wxpython .#SDL --precise --all
these 5 paths will be fetched (4.96 MiB download, 21.60 MiB unpacked):
  /nix/store/vhz0cn55wadyknv3bz4in7drm0mmpny3-SDL_compat-1.2.68
  /nix/store/jfia42fgcpz2gmb5l1mqps5qaaan3lcn-libadwaita-1.6.4
  /nix/store/555981fqc4rkjdfapzsw092bqyrbi5s3-sdl2-compat-2.32.52
  /nix/store/kq5gmdxv139qk1j50grxlqvrsrlx9aq5-sdl3-3.2.6-lib
  /nix/store/d9vlzcqg021zzyw6vwc7dfin8lbm86a1-zenity-4.0.5
'git+file:///home/grimmauld/nixpkgs#python313Packages.wxpython' does not depend on 'git+file:///home/grimmauld/nixpkgs#SDL'
$ nix why-depends .#python313Packages.wxpython .#SDL --derivation --all
/nix/store/79x3l16rh508qmbprz7xslqvd568gd8z-python3.13-wxpython-4.2.2.drv
└───/nix/store/s0kxrg633g9j5yvqiw1d2dgw76hg5r53-SDL_compat-1.2.68.drv

This is output from staging-next branch. Current master still has a dependency via ffmpeg/libvisual which has been dropped on staging. But no direct dependency on SDL either.

Pinging @mweinelt as maintainer of wxpython

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

this dependency was unused:

```
$ nix why-depends .#python313Packages.wxpython .#SDL --precise --all
these 5 paths will be fetched (4.96 MiB download, 21.60 MiB unpacked):
  /nix/store/vhz0cn55wadyknv3bz4in7drm0mmpny3-SDL_compat-1.2.68
  /nix/store/jfia42fgcpz2gmb5l1mqps5qaaan3lcn-libadwaita-1.6.4
  /nix/store/555981fqc4rkjdfapzsw092bqyrbi5s3-sdl2-compat-2.32.52
  /nix/store/kq5gmdxv139qk1j50grxlqvrsrlx9aq5-sdl3-3.2.6-lib
  /nix/store/d9vlzcqg021zzyw6vwc7dfin8lbm86a1-zenity-4.0.5
'git+file:///home/grimmauld/nixpkgs#python313Packages.wxpython' does not depend on 'git+file:///home/grimmauld/nixpkgs#SDL'
```

```
$ nix why-depends .#python313Packages.wxpython .#SDL --derivation --all
/nix/store/79x3l16rh508qmbprz7xslqvd568gd8z-python3.13-wxpython-4.2.2.drv
└───/nix/store/s0kxrg633g9j5yvqiw1d2dgw76hg5r53-SDL_compat-1.2.68.drv
```
@LordGrimmauld LordGrimmauld requested a review from mweinelt March 19, 2025 09:59
@LordGrimmauld LordGrimmauld added the 6.topic: closure size The final size of a derivation, including its dependencies label Mar 19, 2025
@grimmauld-bot
Copy link

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 391240


aarch64-linux

✅ 58 packages built:
  • asn1editor
  • asn1editor.dist
  • chirp
  • chirp.dist
  • displaycal
  • displaycal.dist
  • grass
  • inkscape-extensions.inkstitch
  • inkscape-extensions.silhouette
  • inkscape-extensions.silhouette.dist
  • interactive-html-bom
  • interactive-html-bom.dist
  • kicad
  • kicad-small
  • kicad-testing
  • kicad-testing-small
  • kicad-unstable
  • kicad-unstable-small
  • kicadAddons.kikit
  • kicadAddons.kikit-library
  • kikit
  • kikit.dist
  • loxodo
  • loxodo.dist
  • mavproxy
  • mavproxy.dist
  • meerk40t
  • meerk40t.dist
  • metamorphose2
  • mymcplus
  • mymcplus.dist
  • pixelflasher
  • printrun
  • printrun.dist
  • pyfa
  • python312Packages.fslpy
  • python312Packages.fslpy.dist
  • python312Packages.humblewx
  • python312Packages.humblewx.dist
  • python312Packages.kicad
  • python312Packages.pcbnewtransition
  • python312Packages.pcbnewtransition.dist
  • python312Packages.wxpython
  • python313Packages.fslpy
  • python313Packages.fslpy.dist
  • python313Packages.humblewx
  • python313Packages.humblewx.dist
  • python313Packages.kicad
  • python313Packages.pcbnewtransition
  • python313Packages.pcbnewtransition.dist
  • python313Packages.wxpython
  • quisk
  • quisk.dist
  • timeline
  • woeusb-ng
  • woeusb-ng.dist
  • yt-dlg
  • yt-dlg.dist

@mweinelt mweinelt merged commit cc0e8af into NixOS:master Mar 19, 2025
56 of 60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants