treewide: fix and improve some srcs
#391262
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... and improve some related `meta` URLs
github-actions
bot
added
6.topic: python
6.topic: fetch
drupol
reviewed
Mar 19, 2025
|
Well, I'd say it's out of scope of this, since this PR specifically on purpose does not touch any hashes. |
|
Just replacing the attribute, not its value, and only where it makes sense. And this is in the scope of "improving some e.g.: in |
…ible ... but only when it does not require editing the hash itself, i.e., keeping non-`base64` hashes as-is.
|
Done for all |
drupol
approved these changes
Mar 19, 2025
antonmosich
reviewed
Mar 19, 2025
|
Okay, so apparently Samba mirrors changed their URL scheme again between me making that change and rebasing it on top of master, so that's fixed now.
Also, I checked most of the touched packages by `nix-build`ing their `.src`s with `hashed-mirrors = ` in my `nix.conf` (I checked all where I edited the hash, a bunch of Samba ones, and some random Savannah ones), and everything works.
|
wegank
added
the
12.approvals: 1
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-already-reviewed/2617/2314 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes some source-related build failures I noticed while building nixpkgs without using cache.nixos.org, and then adds some related improvements on top, to make these particular issues less likely in the future.
Things done
sandbox = trueAdd a 👍 reaction to pull requests you find important.