Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mani: refactor and add self as maintainer #391266

Merged
merged 1 commit into from
Mar 19, 2025
Merged

Conversation

phanirithvij
Copy link
Member

@phanirithvij phanirithvij commented Mar 19, 2025

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@phanirithvij

This comment was marked as outdated.

Signed-off-by: phanirithvij <phanirithvij2000@gmail.com>
@phanirithvij
Copy link
Member Author

nixpkgs-reviewd workflow finished

Status and logs: https://github.com/phanirithvij/nixpkgs-reviewd/actions/runs/13951080237

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 391266


aarch64-darwin

✅ 1 package built:
  • mani

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 391266


x86_64-linux

✅ 1 package built:
  • mani

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 391266


aarch64-linux

✅ 1 package built:
  • mani

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 391266


x86_64-darwin

✅ 1 package built:
  • mani

@drupol drupol merged commit cbee7f2 into NixOS:master Mar 19, 2025
33 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants