Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add QF0xB to maintainers-list and nwg-display #391280

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add QF0xB to maintainers-list and nwg-display #391280

wants to merge 2 commits into from

Conversation

QF0xB
Copy link

@QF0xB QF0xB commented Mar 19, 2025

Things done

Add Quirin Brändli (QF0xB) to maintainers-list and nwg-displays.

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Mar 19, 2025
@QF0xB
Copy link
Author

QF0xB commented Mar 19, 2025

Thank you @isabelroses

I apologize for the many mistakes, I shouldn't have made this pull request as I was way too tired.
This should pass now though.

@isabelroses isabelroses added 12.approvals: 1 This PR was reviewed and approved by one reputable person 0.kind: package adoption Requests or PRs for adopting packages that have no maintainers labels Mar 21, 2025
@isabelroses
Copy link
Member

could you squash your fixup actually.

@isabelroses isabelroses self-requested a review March 21, 2025 23:49
@isabelroses isabelroses removed the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Mar 21, 2025
@QF0xB
Copy link
Author

QF0xB commented Mar 22, 2025

Done @isabelroses

@isabelroses
Copy link
Member

can you split it into two commits. sorry about that.

maintainers-list: add QF0xB
and
nwg-displays: adopt package

@QF0xB
Copy link
Author

QF0xB commented Mar 22, 2025

Here you go @isabelroses

@isabelroses isabelroses added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Mar 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isabelroses isabelroses

Assignees
No one assigned
Labels
0.kind: package adoption Requests or PRs for adopting packages that have no maintainers 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@QF0xB @isabelroses