Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubectl-kcl: init at 0.9.0 #391282

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

arichtman
Copy link

Things done

  • Added package for Kubectl plugin KCL
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • [] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` label Mar 19, 2025
@NixOSInfra NixOSInfra added the 12. first-time contribution This PR is the author's first one; please be gentle! label Mar 19, 2025
Copy link
Member

@isabelroses isabelroses left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to nixpkgs

@arichtman arichtman force-pushed the add-package-kubectl-kcl branch from e71e639 to fc54423 Compare March 22, 2025 22:06
Copy link
Member

@isabelroses isabelroses left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

May want to add versionCheckHook though

@isabelroses isabelroses added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Mar 22, 2025
@arichtman arichtman force-pushed the add-package-kubectl-kcl branch 2 times, most recently from 881d97b to 0b7f7a4 Compare March 22, 2025 23:00
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please put this into a separate commit with the message maintainers: add NAME and sort it alphabetically.

Please follow the contributing guide when naming your commits.

@isabelroses isabelroses removed the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Mar 22, 2025
@arichtman arichtman force-pushed the add-package-kubectl-kcl branch from 0b7f7a4 to a72a46e Compare March 22, 2025 23:45
@arichtman
Copy link
Author

You got it, boss. Commits amended and name sorting checked
Unsaved Image 1

@FliegendeWurst FliegendeWurst changed the title feat: add package kubectl-kcl kubectl-kcl: init at 0.9.0 Mar 23, 2025
@arichtman arichtman force-pushed the add-package-kubectl-kcl branch from a72a46e to 56844f9 Compare March 23, 2025 11:04
@FliegendeWurst FliegendeWurst added the 8.has: package (new) This PR adds a new package label Mar 23, 2025
Copy link
Member

@isabelroses isabelroses left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 391282


aarch64-darwin

✅ 1 package built:
  • kubectl-kcl

@isabelroses isabelroses added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Mar 23, 2025
@wegank wegank added 12.approvals: 2 This PR was reviewed and approved by two reputable people and removed 12.approvals: 1 This PR was reviewed and approved by one reputable person labels Mar 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12.approvals: 2 This PR was reviewed and approved by two reputable people 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants