treewide: fix some more sourceRoots
#391287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
6.topic: python
6.topic: coq
nix-owners
bot
requested review from
toonn,
emilazy,
reckenrode,
ttuegel,
K900,
SuperSandro2000 and
NickCao
oxij
force-pushed
the
tree/source-root-continues-4
branch
from
513fdaf to
7374a4c
Compare
oxij
force-pushed
the
tree/source-root-continues-4
branch
from
7374a4c to
d11f8f6
Compare
github-actions
bot
added
10.rebuild-darwin: 1
10.rebuild-darwin: 1-10
and removed
10.rebuild-darwin: 5001+
10.rebuild-darwin: 501+
labels
toastal
reviewed
Mar 19, 2025
oxij
force-pushed
the
tree/source-root-continues-4
branch
from
d11f8f6 to
972ace3
Compare
drupol
requested changes
Mar 20, 2025
pkgs/os-specific/darwin/apple-source-releases/locale/package.nix
Outdated
Show resolved
Hide resolved
This change is almost a noop.
oxij
force-pushed
the
tree/source-root-continues-4
branch
from
972ace3 to
992f592
Compare
|
This needs to target staging. Changing xar and darwin.locale is a whole rebootstrap of Darwin. |
|
It's a no-op unless you enable the |
|
It substitutes the same It is not a noop where I removed |
wegank
added
12.approvals: 2
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-already-reviewed/2617/2314 |
|
ping? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #248528 with more things that were since discovered to be broken with non-default values of
config.fetchedSourceNameDefaultof #49862.I.e. this replaces more references to
fetchzip's "source" insourceRootpackage attribute withsrc.nameand similar.Should be a noop (up to some tiny changes causing micro-rebuilds).