pythonPackages.cpe: replace gpl3Only to lgpl3Only #391315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
6.topic: python
10.rebuild-darwin: 0
Tochiaha
changed the title
Tochiaha
changed the title
|
Can you please also change the commit message to the one you are currently using as PR title. |
Tochiaha
force-pushed
the
python-cpe-licence
branch
from
f3cdb16 to
db4b25c
Compare
Tochiaha
force-pushed
the
python-cpe-licence
branch
from
49b7228 to
aaf33fc
Compare
3 tasks
fabaff
reviewed
Mar 21, 2025
| @@ -31,7 +31,7 @@ buildPythonPackage rec { | |||
| changelog = "https://github.com/nilp0inter/cpe/releases/tag/v${version}"; | |||
| description = "Common platform enumeration for python"; | |||
| homepage = "https://github.com/nilp0inter/cpe"; | |||
| license = lib.licenses.gpl3Only; | |||
| license = lib.licenses.lgpl3Only; | |||
There was a problem hiding this comment.
The file header looks like LGPLv3+ as "..or (at your option) any later version." was not removed.
Suggested change
| license = lib.licenses.lgpl3Only; | |
| license = lib.licenses.lgpl3Plus; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes made on just the license, clearly missed out the last time after been corrected. As recommended by @armijnhemel in #391267 changes applied for correct licensing.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.