[Backport release-24.11] build-support/rust/sysroot: remove #391339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The sysroot derivation used by buildRustPackage hasn't built since c263e0b ("cargo,clippy,rustc,rustfmt: 1.81.0 -> 1.82.0"). That means that it's never built on 24.11, so there can't be anybody relying on it working on any supported version Nixpkgs. In the meantime, it's causing maintenance friction — I've spent a lot of time trying to figure out how to build it as part of the transition away from fetchCargoTarball, before realising that it doesn't work anyway and must be unused. It can come back in the future if somebody wants to maintain it. (cherry picked from commit c8127fc)
github-actions
bot
added
6.topic: rust
10.rebuild-darwin: 0
|
|
The CI check The difference seems to caused by conflict resolution, and the only change I made is to select changes from the feature and discard those from the base branch at the spot of conflict. |
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR manually backports PR #378006 to ease the backport of PR #382550.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truetests.overridingandtests.buildRustCrate)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.