Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

julec: 0.1.3 -> 0.1.4 #391345

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

julec: 0.1.3 -> 0.1.4 #391345

wants to merge 1 commit into from

Conversation

adamperkowski
Copy link
Member

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@adamperkowski
Copy link
Member Author

Also please take a look at #379891 (comment).

@philiptaron
Copy link
Contributor

philiptaron commented Mar 19, 2025

If you use clangStdenv instead of stdenv, that gets your clang desires sorted.

Since it's not bit-for-bit identical, and is a self-hosted compiler, it seems best to me to have the julec that everyone downloads be the self-hosted version, not the bootstrap one.

@philiptaron
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 391345


x86_64-linux

✅ 1 package built:
  • julec

@adamperkowski
Copy link
Member Author

If you use clangStdenv instead of stdenv, that gets your clang desires sorted.

Since it's not bit-for-bit identical, and is a self-hosted compiler, it seems best to me to have the julec that everyone downloads be the self-hosted version, not the bootstrap one.

thanks. applied.

philiptaron
philiptaron previously approved these changes Mar 19, 2025
@philiptaron
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 391345


x86_64-linux

❌ 1 package failed to build:
  • julec

@philiptaron philiptaron dismissed their stale review March 19, 2025 20:20

Whoops, didn't build.

/nix/store/glqkrbbjiacf0pqajczzsv2syzv4580w-stdenv-linux/setup: line 1777:    40 Segmentation fault      (core dumped) bin/julec-bootstrap --opt L2 -p -o "bin/julec" "src/julec"
@adamperkowski
Copy link
Member Author

adamperkowski commented Mar 19, 2025

hmm... that's weird... seems to be an issue with the compiler as i have encountered this before. we're working on it. drafting this for now.

@adamperkowski adamperkowski marked this pull request as draft March 19, 2025 20:32
@adamperkowski adamperkowski marked this pull request as ready for review March 19, 2025 21:52
@adamperkowski adamperkowski marked this pull request as draft March 19, 2025 22:06
Co-authored-by: Sebaguardian <sebaguardian13@gmail.com>
Co-authored-by: mertcandav <mertcandav@outlook.com>
Signed-off-by: Adam Perkowski <adas1per@protonmail.com>
@adamperkowski adamperkowski marked this pull request as ready for review March 21, 2025 17:37
@adamperkowski
Copy link
Member Author

@philiptaron There was a bug in Jule's memcopy function (unsafe pointer handling) that resulted in a segfault when combined with Clang's O3 & LTO. Everything's fixed now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants