Reapply "build(deps): bump cachix/install-nix-action from 30 to 31" #391347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
6.topic: continuous integration
nix-owners
bot
requested review from
risicle,
LeSuisse,
zowoq,
mweinelt,
azuwis and
infinisil
wolfgangwalther
force-pushed
the
ci-install-nix-action-31
branch
from
3b103b9 to
f007f20
Compare
github-actions
bot
added
10.rebuild-darwin: 0
philiptaron
approved these changes
Mar 19, 2025
This suddenly appeared after updating Nix to v26, which then complained:
… while calling the 'fromJSON' builtin
at
/home/runner/work/nixpkgs/nixpkgs/target/ci/eval/compare/default.nix:74:19:
73|
74| getAttrs = dir: builtins.fromJSON (builtins.readFile
"${dir}/outpaths.json");
| ^
75| beforeAttrs = getAttrs beforeResultDir;
… while evaluating the first argument passed to builtins.fromJSON
error: the string '{
"AMB-plugins.aarch64-linux": {
"out":
"/nix/store/faw59ba5p6h4b177n8q2ilb3hlm7xlc2-AMB-plugins-0.8.1"
},
....
"zzuf.aarch64-linux": {
"out": "/nix/store/bqvm1h7jfd8smgnjc1v1gpmbwdgvwy5g-zzuf-0.15"
},
"zzuf.x86_64-linux": {
"out": "/nix/store/6qs4lnmzn1qlr3smqqxnmhnrcdcfiv6a-zzuf-0.15"
}
}
' is not allowed to refer to a store path (such as
'134m2q047vsr9miwh5l227j7sh9jb130-jq-1.7.1-bin')
By discard the unsafe string context, we explicitly allow loading those
store paths. It's unclear why this blew up now, especially because I was
not possible to consistently replicate this locally, so far.
This reverts commit 2818752.
wolfgangwalther
force-pushed
the
ci-install-nix-action-31
branch
from
f007f20 to
3fa48f3
Compare
philiptaron
approved these changes
Mar 19, 2025
Mic92
approved these changes
Mar 19, 2025
wegank
added
the
12.approvals: 2
|
Successfully created backport PR for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was reverted in #390695, more discussion over there.
I was not able to reproduce the problem locally, but easily in my own fork by re-applying the commit:
https://github.com/wolfgangwalther/nixpkgs/actions/runs/13953151439/job/39057945183
I then applied the fix as suggested by @Mic92 in #390695 (comment). This fixed it.
I also double-checked, the other uses of
builtins.fromJSON(as well asbuiltins.readFile) in the ci-code are not going to deal with store paths, this is the only case.Thus, it should be safe to re-apply this again.
Things done
Add a 👍 reaction to pull requests you find important.