Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

orthanc-framework: init at 1.12.6, orthanc-plugin-dicomweb: init at 1.18 #391361

Merged
merged 6 commits into from
Mar 22, 2025
Merged

orthanc-framework: init at 1.12.6, orthanc-plugin-dicomweb: init at 1.18 #391361

merged 6 commits into from
Mar 22, 2025
+188 −3

Conversation

drupol
Copy link
Contributor

@drupol drupol commented Mar 19, 2025

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@drupol drupol requested a review from dvcorreia March 19, 2025 19:36
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Mar 19, 2025
@drupol drupol force-pushed the push-qwqxxrusmlmn branch from 3e13179 to ab8d249 Compare March 19, 2025 20:20
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Mar 19, 2025
@drupol drupol force-pushed the push-qwqxxrusmlmn branch from bb1924f to ac0db37 Compare March 20, 2025 13:58
@drupol drupol force-pushed the push-qwqxxrusmlmn branch from ac0db37 to b49b235 Compare March 20, 2025 16:47
@drupol drupol marked this pull request as ready for review March 22, 2025 14:43
@drupol drupol merged commit 588f479 into NixOS:master Mar 22, 2025
40 checks passed
@drupol drupol deleted the push-qwqxxrusmlmn branch March 22, 2025 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dvcorreia dvcorreia

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@drupol @dvcorreia