Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddnet-server: build fixes #391366

Merged
merged 2 commits into from
Mar 25, 2025
Merged

ddnet-server: build fixes #391366

merged 2 commits into from
Mar 25, 2025

Conversation

Scrumplex
Copy link
Member

@Scrumplex Scrumplex commented Mar 19, 2025 •
edited
Loading

Documented my changes in the respective commits (where applicable)

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Scrumplex
ddnet-server: fix Darwin build
acd3e90 
The server variant of the ddnet package does not ship the client, so we
don't need to patch in libsteam_api.dylib

Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net>
@Scrumplex
ddnet-server: set correct mainProgram
894f30e 
Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net>
@Scrumplex Scrumplex changed the title ddnet-server: general fixes ddnet-server: build fixes Mar 19, 2025
@github-actions github-actions bot added 10.rebuild-darwin: 1 10.rebuild-darwin: 1-10 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Mar 19, 2025
@jopejoe1 jopejoe1 merged commit e77c283 into NixOS:master Mar 25, 2025
43 checks passed
@Scrumplex Scrumplex deleted the pkgs/ddnet-server/fixes branch March 25, 2025 13:10
@Scrumplex Scrumplex added the backport release-24.11 Backport PR automatically label Mar 25, 2025
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Mar 25, 2025

Successfully created backport PR for release-24.11:

@nixpkgs-ci nixpkgs-ci bot mentioned this pull request Mar 25, 2025
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jopejoe1 jopejoe1

@legendofmiracles legendofmiracles

@ncfavier ncfavier

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux backport release-24.11 Backport PR automatically
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Scrumplex @jopejoe1