Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git-gamble: 2.9.0 -> 2.10.0 #391370

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

r-ryantm
Copy link
Contributor

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.

meta.description for git-gamble is: Tool that blends TDD (Test Driven Development) + TCR (test && commit || revert)

meta.homepage for git-gamble is: https://git-gamble.is-cool.dev

meta.changelog for git-gamble is: https://gitlab.com/pinage404/git-gamble/-/blob/version/2.10.0/CHANGELOG.md

Updates performed
  • Ran passthru.UpdateScript
To inspect upstream changes
Impact

Checks done


  • built on NixOS
  • The tests defined in passthru.tests, if any, passed
  • found 2.10.0 with grep in /nix/store/h4dxnd89p3ajxihcf3m9xynfykb6qz7s-git-gamble-2.10.0
  • found 2.10.0 in filename of file in /nix/store/h4dxnd89p3ajxihcf3m9xynfykb6qz7s-git-gamble-2.10.0

Rebuild report (if merged into master) (click to expand)
2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath

git-gamble
Instructions to test this update (click to expand)

Either download from the cache:

nix-store -r /nix/store/h4dxnd89p3ajxihcf3m9xynfykb6qz7s-git-gamble-2.10.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nixpkgs-update-cache.nix-community.org/' \
  --option trusted-public-keys '
  nixpkgs-update-cache.nix-community.org-1:U8d6wiQecHUPJFSqHN9GSSmNkmdiFW7GW7WNAnHW0SM=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The nixpkgs-update cache is only trusted for this store-path realization.)
For the cached download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A git-gamble https://github.com/r-ryantm/nixpkgs/archive/cc6392ee5850604183aa7de0e2469620a1ea06bf.tar.gz

Or:

nix build github:r-ryantm/nixpkgs/cc6392ee5850604183aa7de0e2469620a1ea06bf#git-gamble

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/h4dxnd89p3ajxihcf3m9xynfykb6qz7s-git-gamble-2.10.0
ls -la /nix/store/h4dxnd89p3ajxihcf3m9xynfykb6qz7s-git-gamble-2.10.0/bin


Pre-merge build results

We have automatically built all packages that will get rebuilt due to
this change.

This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review


x86_64-linux

✅ 1 package built:
  • git-gamble

Maintainer pings

cc @pinage404 for testing.

Tip

As a maintainer, if your package is located under pkgs/by-name/*, you can comment @NixOS/nixpkgs-merge-bot merge to automatically merge this update using the nixpkgs-merge-bot.


Add a 👍 reaction to pull requests you find important.

@wegank wegank added 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package 12.approvals: 1 This PR was reviewed and approved by one reputable person labels Mar 20, 2025
@khaneliman
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 391370


x86_64-linux

✅ 1 package built:
  • git-gamble

aarch64-linux

❌ 1 package failed to build:
  • git-gamble

x86_64-darwin

❌ 1 package failed to build:
  • git-gamble

aarch64-darwin

✅ 1 package built:
  • git-gamble

@khaneliman
Copy link
Contributor

> thread 'git_time_keeper::white_box::lock_file::create_as_many_as_lock_files_when_starting_several_times' panicked at tests/fixture/test_repository/test_repository_lock_file_assertions.rs:1…
┃        >> 	expected: <2>> 	but was: <1>>>>> failures:
┃        >     git_time_keeper::white_box::lock_file::create_as_many_as_lock_files_when_starting_several_times
┃        >> test result: FAILED. 143 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out; finished in 2.66s
┃        >

@wegank wegank added 12.approvals: 2 This PR was reviewed and approved by two reputable people and removed 12.approvals: 1 This PR was reviewed and approved by one reputable person labels Mar 21, 2025
@pinage404
Copy link
Contributor

@khaneliman This test used to be flaky and was disabled since a long time https://gitlab.com/pinage404/git-gamble/-/commit/78144b71e7f9007574fe2f06b51d5785a6980177

After recent changes, i didn't see it failing again and seems stabilized

I re-enabled this test https://gitlab.com/pinage404/git-gamble/-/commit/9c3f28300268754595b3560b91899898b06b7ba0

I don't know how to have a permanent robust fix, i need help

Should i disable this test ?

@khaneliman
Copy link
Contributor

@khaneliman This test used to be flaky and was disabled since a long time https://gitlab.com/pinage404/git-gamble/-/commit/78144b71e7f9007574fe2f06b51d5785a6980177

After recent changes, i didn't see it failing again and seems stabilized

I re-enabled this test https://gitlab.com/pinage404/git-gamble/-/commit/9c3f28300268754595b3560b91899898b06b7ba0

I don't know how to have a permanent robust fix, i need help

Should i disable this test ?

Ah, interesting. Yeah, it might be best to skip a flaky test if its a known issue. We could update the derivation:

  checkFlags = [
    # reason for disabling test
    "--skip=example::tests:example_test"
  ];

@pinage404
Copy link
Contributor

i don't know how to push on this PR

@khaneliman
Copy link
Contributor

i don't know how to push on this PR

You could create a new PR that has the change and in the description note that it closes this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12.approvals: 2 This PR was reviewed and approved by two reputable people 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants