-
-
Notifications
You must be signed in to change notification settings - Fork 15.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
git-gamble: 2.9.0 -> 2.10.0 #391370
base: master
Are you sure you want to change the base?
git-gamble: 2.9.0 -> 2.10.0 #391370
Conversation
|
> thread 'git_time_keeper::white_box::lock_file::create_as_many_as_lock_files_when_starting_several_times' panicked at tests/fixture/test_repository/test_repository_lock_file_assertions.rs:1…
┃ >
┃ > expected: <2>
┃ > but was: <1>
┃ >
┃ >
┃ >
┃ > failures:
┃ > git_time_keeper::white_box::lock_file::create_as_many_as_lock_files_when_starting_several_times
┃ >
┃ > test result: FAILED. 143 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out; finished in 2.66s
┃ > |
@khaneliman This test used to be flaky and was disabled since a long time https://gitlab.com/pinage404/git-gamble/-/commit/78144b71e7f9007574fe2f06b51d5785a6980177 After recent changes, i didn't see it failing again and seems stabilized I re-enabled this test https://gitlab.com/pinage404/git-gamble/-/commit/9c3f28300268754595b3560b91899898b06b7ba0 I don't know how to have a permanent robust fix, i need help Should i disable this test ? |
Ah, interesting. Yeah, it might be best to skip a flaky test if its a known issue. We could update the derivation: checkFlags = [
# reason for disabling test
"--skip=example::tests:example_test"
]; |
i don't know how to push on this PR |
You could create a new PR that has the change and in the description note that it closes this one. |
Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for git-gamble is: Tool that blends TDD (Test Driven Development) + TCR (
test && commit || revert
)meta.homepage for git-gamble is: https://git-gamble.is-cool.dev
meta.changelog for git-gamble is: https://gitlab.com/pinage404/git-gamble/-/blob/version/2.10.0/CHANGELOG.md
Updates performed
To inspect upstream changes
Impact
Checks done
passthru.tests
, if any, passedRebuild report (if merged into master) (click to expand)
Instructions to test this update (click to expand)
Either download from the cache:
(The nixpkgs-update cache is only trusted for this store-path realization.)
For the cached download to work, your user must be in the
trusted-users
list or you can usesudo
since root is effectively trusted.Or, build yourself:
Or:
After you've downloaded or built it, look at the files and if there are any, run the binaries:
Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
nixpkgs-review
resultGenerated using
nixpkgs-review
.Command:
nixpkgs-review
x86_64-linux
✅ 1 package built:
Maintainer pings
cc @pinage404 for testing.
Tip
As a maintainer, if your package is located under
pkgs/by-name/*
, you can comment@NixOS/nixpkgs-merge-bot merge
to automatically merge this update using thenixpkgs-merge-bot
.Add a 👍 reaction to pull requests you find important.