Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

postgresqlJitPackages.timescaledb: fix build #391374

Merged
merged 1 commit into from
Mar 19, 2025
Merged

postgresqlJitPackages.timescaledb: fix build #391374

merged 1 commit into from
Mar 19, 2025

Conversation

sikmir
Copy link
Member

@sikmir sikmir commented Mar 19, 2025

#390965 breaks postgresqlJitPackages.timescaledb (only on linux), while postgresqlPackages.timescaledb is OK. LINTER is OFF by default.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@sikmir sikmir requested a review from wolfgangwalther March 19, 2025 20:42
@nix-owners nix-owners bot requested review from Ma27 and thoughtpolice March 19, 2025 20:43
@sikmir sikmir changed the title postgresqlPackages.timescaledb: fix build postgresqlJitPackages.timescaledb: fix build Mar 19, 2025
@nix-owners nix-owners bot requested a review from kirillrdy March 19, 2025 20:50
@wolfgangwalther
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 391374

x86_64-linux

⏩ 4 packages marked as broken and skipped:
  • postgresql13JitPackages.timescaledb
  • postgresql13JitPackages.timescaledb-apache
  • postgresql13Packages.timescaledb
  • postgresql13Packages.timescaledb-apache
✅ 16 packages built:
  • postgresql14JitPackages.timescaledb
  • postgresql14JitPackages.timescaledb-apache
  • postgresql14Packages.timescaledb
  • postgresql14Packages.timescaledb-apache
  • postgresql15JitPackages.timescaledb
  • postgresql15JitPackages.timescaledb-apache
  • postgresql15Packages.timescaledb
  • postgresql15Packages.timescaledb-apache
  • postgresql16JitPackages.timescaledb
  • postgresql16JitPackages.timescaledb-apache
  • postgresql16Packages.timescaledb
  • postgresql16Packages.timescaledb-apache
  • postgresqlJitPackages.timescaledb (postgresql17JitPackages.timescaledb)
  • postgresqlJitPackages.timescaledb-apache (postgresql17JitPackages.timescaledb-apache)
  • postgresqlPackages.timescaledb (postgresql17Packages.timescaledb)
  • postgresqlPackages.timescaledb-apache (postgresql17Packages.timescaledb-apache)

aarch64-linux

⏩ 4 packages marked as broken and skipped:
  • postgresql13JitPackages.timescaledb
  • postgresql13JitPackages.timescaledb-apache
  • postgresql13Packages.timescaledb
  • postgresql13Packages.timescaledb-apache
✅ 16 packages built:
  • postgresql14JitPackages.timescaledb
  • postgresql14JitPackages.timescaledb-apache
  • postgresql14Packages.timescaledb
  • postgresql14Packages.timescaledb-apache
  • postgresql15JitPackages.timescaledb
  • postgresql15JitPackages.timescaledb-apache
  • postgresql15Packages.timescaledb
  • postgresql15Packages.timescaledb-apache
  • postgresql16JitPackages.timescaledb
  • postgresql16JitPackages.timescaledb-apache
  • postgresql16Packages.timescaledb
  • postgresql16Packages.timescaledb-apache
  • postgresqlJitPackages.timescaledb (postgresql17JitPackages.timescaledb)
  • postgresqlJitPackages.timescaledb-apache (postgresql17JitPackages.timescaledb-apache)
  • postgresqlPackages.timescaledb (postgresql17Packages.timescaledb)
  • postgresqlPackages.timescaledb-apache (postgresql17Packages.timescaledb-apache)

x86_64-darwin

⏩ 4 packages marked as broken and skipped:
  • postgresql13JitPackages.timescaledb
  • postgresql13JitPackages.timescaledb-apache
  • postgresql13Packages.timescaledb
  • postgresql13Packages.timescaledb-apache
✅ 16 packages built:
  • postgresql14JitPackages.timescaledb
  • postgresql14JitPackages.timescaledb-apache
  • postgresql14Packages.timescaledb
  • postgresql14Packages.timescaledb-apache
  • postgresql15JitPackages.timescaledb
  • postgresql15JitPackages.timescaledb-apache
  • postgresql15Packages.timescaledb
  • postgresql15Packages.timescaledb-apache
  • postgresql16JitPackages.timescaledb
  • postgresql16JitPackages.timescaledb-apache
  • postgresql16Packages.timescaledb
  • postgresql16Packages.timescaledb-apache
  • postgresqlJitPackages.timescaledb (postgresql17JitPackages.timescaledb)
  • postgresqlJitPackages.timescaledb-apache (postgresql17JitPackages.timescaledb-apache)
  • postgresqlPackages.timescaledb (postgresql17Packages.timescaledb)
  • postgresqlPackages.timescaledb-apache (postgresql17Packages.timescaledb-apache)

aarch64-darwin

⏩ 4 packages marked as broken and skipped:
  • postgresql13JitPackages.timescaledb
  • postgresql13JitPackages.timescaledb-apache
  • postgresql13Packages.timescaledb
  • postgresql13Packages.timescaledb-apache
❌ 4 packages failed to build:
  • postgresql15JitPackages.timescaledb
  • postgresql15JitPackages.timescaledb-apache
  • postgresql16Packages.timescaledb
  • postgresql16Packages.timescaledb-apache
✅ 12 packages built:
  • postgresql14JitPackages.timescaledb
  • postgresql14JitPackages.timescaledb-apache
  • postgresql14Packages.timescaledb
  • postgresql14Packages.timescaledb-apache
  • postgresql15Packages.timescaledb
  • postgresql15Packages.timescaledb-apache
  • postgresql16JitPackages.timescaledb
  • postgresql16JitPackages.timescaledb-apache
  • postgresqlJitPackages.timescaledb (postgresql17JitPackages.timescaledb)
  • postgresqlJitPackages.timescaledb-apache (postgresql17JitPackages.timescaledb-apache)
  • postgresqlPackages.timescaledb (postgresql17Packages.timescaledb)
  • postgresqlPackages.timescaledb-apache (postgresql17Packages.timescaledb-apache)

aarch64-darwin failures unrelated to this PR.

@wolfgangwalther wolfgangwalther merged commit fdc4f79 into NixOS:master Mar 19, 2025
33 of 35 checks passed
@sikmir sikmir deleted the timescaledb branch March 19, 2025 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wolfgangwalther wolfgangwalther

@Ma27 Ma27

@thoughtpolice thoughtpolice

@kirillrdy kirillrdy

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sikmir @wolfgangwalther