nixos/version: show system name in stateVersion warning #391388
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
6.topic: nixos
Currently ther is no way to figure out if the warning is for the host or for a container or some other virtualized system crated by NixOS. Signed-off-by: Jakub Sokołowski <jakub@status.im>
jakubgs
force-pushed
the
fix/stateVersion-warn
branch
from
a5921b1 to
af6b66a
Compare
|
I have tested this on my own setup and it works: I wonder if there's anything else we could print to more clearly indicate which config caused this. |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/why-am-i-getting-system-stateversion-is-not-set/61923/17 |
SigmaSquadron
approved these changes
Mar 22, 2025
|
As discussed in the linked discourse thread, adding hostname in a one-off way to warnings/errors (as this PR does) doesn't substantively improve the debugging situation. It'd have to be added to every single warning/error in that case. Module system debugging is awful but this doesn't seem to be a sustainable solution. |
wegank
added
the
12.approvals: 1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently ther is no way to figure out if the warning is for the host or for a container or some other virtualized system crated by NixOS.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.