[Backport release-24.11] buildRustPackage: support fixed-point arguments via lib.extendMkDerivation #391398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move assertions down to the corresponding attribute value. Avoid adding assertions to the whole argument set. (cherry picked from commit 016ba92)
Support fixed-point arguments with lib.extendMkDerivation Postpone formatting for more concise diff. (cherry picked from commit 7609cba)
Manual reproduction of commit 721751b
|
@GaetanLepage Could you help test if this makes the desired Rust package backports work? |
github-actions
bot
added
10.rebuild-darwin: 0
It seems to work fine indeed. I was able to migrate a package to the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the manual backport of PR #382550.
This PR enables future backports of Rust package changes which use
finalAttrs.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.