Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vintagestory: 1.20.4 -> 1.20.5 #391401

Merged
merged 1 commit into from
Mar 22, 2025

Conversation

KamilBaczkowski
Copy link
Contributor

A minor update to Vintage Story. Changelog

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

I have launched the game and played it for a big, everything worked as expected.

@NixOSInfra NixOSInfra added the 12. first-time contribution This PR is the author's first one; please be gentle! label Mar 19, 2025
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1 10.rebuild-linux: 1-10 labels Mar 19, 2025
@osbm
Copy link
Member

osbm commented Mar 19, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 391401


x86_64-linux

⏩ 1 package marked as broken and skipped:
  • vintagestory

@osbm
Copy link
Member

osbm commented Mar 19, 2025

dotnet-runtime_7 is marked as unsafe. Can we use the v8? Or does this have to be updated upstream?

@niraethm
Copy link
Contributor

vintagestory requires .NET 7 runtime, that would be why it is saying broken and skipped most likely.

After running NIXPKGS_ALLOW_UNFREE=1 NIXPKGS_ALLOW_INSECURE=1 nix-build -A vintagestory it'll build and run fine.

@GiggleSquid
Copy link
Contributor

GiggleSquid commented Mar 19, 2025

As niraethm said ^

Also see #360384 (comment)

@GiggleSquid
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 391401


x86_64-linux

✅ 1 package built:
  • vintagestory

@wegank wegank added 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package 12.approvals: 2 This PR was reviewed and approved by two reputable people labels Mar 20, 2025
@bbigras
Copy link
Contributor

bbigras commented Mar 22, 2025

1.20.6 is out btw

@khaneliman khaneliman merged commit 1734963 into NixOS:master Mar 22, 2025
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12.approvals: 2 This PR was reviewed and approved by two reputable people 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants