-
-
Notifications
You must be signed in to change notification settings - Fork 15.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lix: package nix-eval-jobs
#391402
lix: package nix-eval-jobs
#391402
Conversation
@@ -1,13 +1,13 @@ | |||
{ | |||
lib, | |||
fetchFromGitHub, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This wasn't used, is it needed for anything?
df5a111
to
9adf275
Compare
Open question: What should the structure of the attribute set be? PreviousThis is what it previously looked like:
Pros:
Cons:
LLVM-styleWe could have it be like LLVM or the Linux kernel:
Pros:
Cons:
Compromise-ishThis is the new structure I went with:
Pros:
Cons:
Compromise-ish 2Having top-level aliases is seen as clumsy and leading to bad code, particularly with LLVM and kernel package sets. Here's the new new structure:
Pros:
Cons:
|
f0e3547
to
3c903ad
Compare
3c903ad
to
7b44a79
Compare
7b44a79
to
ea9ee5c
Compare
|
||
# point 'nix edit' and ofborg at the file that defines the attribute, | ||
# not this common file. | ||
pos = builtins.unsafeGetAttrPos "version" args; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh gods. that's a special argument to mkDerivation that looks like it is supposed to land in drvAttrs but actually doesn't? that's some evil API design in mkDerivation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tbh i assumed you wrote it from the comment but it appears to be a @RaitoBezarius special from #310194
ea9ee5c
to
806e8e7
Compare
; | ||
|
||
boehmgc = | ||
# TODO: Why is this called `boehmgc-nix_2_3`? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
um. great question. i dont know. probably because it was introduced due to nix 2.3?
version = "2.90.0"; | ||
src = fetchgit { | ||
url = "https://git.lix.systems/lix-project/nix-eval-jobs.git"; | ||
# https://git.lix.systems/lix-project/nix-eval-jobs/commits/branch/release-2.90 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lol we didn't tag these huh. the canonical source for the version that shipped with a given lix is then the nixos module (which is PROBABLY just the branch tip of release-*). clown shoes on our part. you or i should tag these upstream.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay im just going to do it, it will take 5 mins.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2.91.1 and 2.90.0 and 2.92.0 tags now exist.
This adds packaging for the Lix fork of `nix-eval-jobs`. `lixVersions.lix_2_91` has been renamed to `lixPackageSets.lix_2_91.lix`. The elements of `lixPackageSets` are proper scopes instead of single packages. This makes it easy to build `nix-eval-jobs` against the correct version of Lix.
806e8e7
to
8994076
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved pending doing a quick QA to make sure it doesn't blow up the module
Passes my brief QA so should be good to go. |
This adds packaging for the Lix fork of
nix-eval-jobs
.lixVersions.lix_2_91
has been renamed tolixPackageSets.lix_2_91.lix
.The elements of
lixPackageSets
are proper scopes instead of single packages. This makes it easy to buildnix-eval-jobs
against the correct version of Lix.TODO:
nix-eval-jobs
orlix-eval-jobs
?Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.