Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

granted: fix config folder #391403

Merged
merged 1 commit into from
Mar 24, 2025
Merged

granted: fix config folder #391403

merged 1 commit into from
Mar 24, 2025
+1 −0

Conversation

fzakaria
Copy link
Contributor

The config folder in granted is set to .dgranted by default. https://github.com/common-fate/granted/blob/e1f1b5ab75424d4534ac715c33d6d1049936e3ba/internal/build/config.go#L5

The d is the "development.

Looks like in a typical release process this is overwritten to be .granted.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@fzakaria
granted: fix config folder
d87d015 
The config folder in granted is set to `.dgranted` by default.
https://github.com/common-fate/granted/blob/e1f1b5ab75424d4534ac715c33d6d1049936e3ba/internal/build/config.go#L5

The `d` is the "development.

Looks like in a typical release process this is overwritten to be `.granted`.
@fzakaria fzakaria requested a review from jlbribeiro March 19, 2025 23:36
@pbsds pbsds merged commit 0b7c160 into NixOS:master Mar 24, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlbribeiro jlbribeiro

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fzakaria @pbsds