Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

capnproto: build shared libs, debuginfo, etc. #391424

Merged
merged 1 commit into from
Mar 21, 2025
Merged

Conversation

9999years
Copy link
Contributor

@9999years 9999years commented Mar 20, 2025

This makes several improvements to the capnproto derivation:

See: https://git.lix.systems/lix-project/lix/issues/527

This upstreams the fixes from https://gerrit.lix.systems/c/lix/+/2074

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

This makes several improvements to the `capnproto` derivation:
- Build shared libs
- Build debuginfo
  See: https://git.lix.systems/lix-project/lix/issues/550
- Set the correct cmake build type
- Set the correct cxxflags to build the coroutine library
- Always build with clang
- Work around a broken static build
  See: avdv/scalals@a2de0ef

See: https://git.lix.systems/lix-project/lix/issues/527

This upstreams the fixes from https://gerrit.lix.systems/c/lix/+/2074
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Mar 21, 2025
@lf- lf- merged commit 3a593e6 into NixOS:master Mar 21, 2025
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants