heynote: init at 2.1.3 #391457
Open
heynote: init at 2.1.3 #391457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
8.has: maintainer-list (update)
NixOSInfra
added
the
12. first-time contribution
github-actions
bot
added
10.rebuild-darwin: 0
QF0xB
suggested changes
Mar 20, 2025
|
Looks good now, did not feature test, yet. |
QF0xB
reviewed
Mar 21, 2025
awwpotato
suggested changes
Mar 23, 2025
pkgs/by-name/he/heynote/package.nix
Outdated
Comment on lines
40
to
49
| meta = with lib; { | ||
| description = "Dedicated scratchpad for developers"; | ||
| homepage = "https://heynote.com/"; | ||
| license = with licenses; [ | ||
| mit | ||
| commons-clause | ||
| ]; | ||
| maintainers = with maintainers; [ jasoncrevier ]; | ||
| platforms = platforms.x86_64; | ||
| }; |
There was a problem hiding this comment.
Suggested change
| meta = with lib; { | |
| description = "Dedicated scratchpad for developers"; | |
| homepage = "https://heynote.com/"; | |
| license = with licenses; [ | |
| mit | |
| commons-clause | |
| ]; | |
| maintainers = with maintainers; [ jasoncrevier ]; | |
| platforms = platforms.x86_64; | |
| }; | |
| meta = { | |
| description = "Dedicated scratchpad for developers"; | |
| homepage = "https://heynote.com/"; | |
| license = with lib.licenses; [ | |
| mit | |
| commons-clause | |
| ]; | |
| maintainers = with lib.maintainers; [ jasoncrevier ]; | |
| platforms = lib.platforms.x86_64; | |
| }; |
There was a problem hiding this comment.
And add mainProgram = "heynote" to meta
|
|
||
| meta = with lib; { | ||
| description = "Dedicated scratchpad for developers"; | ||
| homepage = "https://heynote.com/"; |
There was a problem hiding this comment.
Suggested change
| homepage = "https://heynote.com/"; | |
| homepage = "https://heynote.com/"; | |
| changelog = "https://github.com/heyman/heynote/releases/v${version}"; |
pkgs/by-name/he/heynote/package.nix
Outdated
Comment on lines
30
to
31
| mv $out/bin/${pname} $out/bin/heynote-temp | ||
| mv $out/bin/heynote-temp $out/bin/heynote |
There was a problem hiding this comment.
Suggested change
| mv $out/bin/${pname} $out/bin/heynote-temp | |
| mv $out/bin/heynote-temp $out/bin/heynote | |
| # verify binary is present | |
| stat $out/bin/heynote |
There was a problem hiding this comment.
With this change I get the error: cp: cannot stat '/nix/store/s1xsf1cvy298sdgd4m1ma6bnnhl6mk6p-heynote-2.1.3-extracted/LICENSE.heynote.txt': No such file or directory
There was a problem hiding this comment.
Not related to this change, but to the line above.
There was a problem hiding this comment.
You're correct, thanks -- removed that above line and it builds.
pkgs/by-name/he/heynote/package.nix
Outdated
Comment on lines
32
to
33
| ${desktop-file-utils}/bin/desktop-file-install --dir $out/share/applications \ | ||
| --set-key Exec --set-value $out/bin/heynote \ |
There was a problem hiding this comment.
Suggested change
| ${desktop-file-utils}/bin/desktop-file-install --dir $out/share/applications \ | |
| --set-key Exec --set-value $out/bin/heynote \ | |
| desktop-file-install --dir $out/share/applications \ | |
| --set-key Exec --set-value heynote \ |
Add desktop-file-utils to nativeBuildInputs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.