tsx: init at 4.19.3 #391467
Open
tsx: init at 4.19.3 #391467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdedovic
force-pushed
the
init-tsx
branch
2 times, most recently
from
4bcb086 to
332bbdc
Compare
|
ethancedwards8
suggested changes
Mar 20, 2025
github-actions
bot
added
the
8.has: maintainer-list (update)
ethancedwards8
suggested changes
Mar 22, 2025
ethancedwards8
suggested changes
Mar 23, 2025
| ''; | ||
|
|
||
| # 8 / 85 tests are failing, I do not know why, while regular usage shows no issues. | ||
| doCheck = false; |
There was a problem hiding this comment.
disable those 8 tests then.
There was a problem hiding this comment.
I disagree. I don't know why the tests fail. I don't know if they only fail on my x86_linux or if they fail on other architectures (aarch64) and other OSs (darwin). So I don't want to maintain the check phase being dependent on the tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Homepage: https://tsx.is
Description: TSX is an environment to natively execute typescript code with Node.js. It is more actively developed than ts-node.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.