Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ryubing: only link to sndio on linux #391541

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

06kellyjac
Copy link
Member

Things done

Attempting to resolve #391360

Linking to sndio was added in PR: #165756
I wonder if it's still necessary.
Need to check things still work for darwin aarch64

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 1 10.rebuild-darwin: 1-10 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Mar 20, 2025
@nix-owners nix-owners bot requested review from artemist and Kek5chen March 20, 2025 11:29
@JohnRTitor
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 391541

Logs: https://github.com/JohnRTitor/nixpkgs-review-gha/actions/runs/13969283966


aarch64-darwin

✅ 1 package built:
  • ryubing

@06kellyjac
Copy link
Member Author

Thanks for running the test @JohnRTitor
Would you be able to confirm that:

  1. Ryubing runs correctly as you generally use/test it
  2. That it continues to run with sndio enabled in the settings (if that's an option on darwin)

@JohnRTitor
Copy link
Contributor

Better to ask a darwin maintainer, I just ran Nixpkgs review on a remote builder, I don't have access to a Mac.

If nobody's around to test this feature, you could just leave it as it is, someone will file a bug report eventually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ryubing: noBrokenSymlinks: found 1 dangling symlinks and 0 reflexive symlinks on aarch64-darwin
2 participants