Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mosdepth: loosen compiler pointer checks #391543

Merged
merged 1 commit into from
Mar 24, 2025
Merged

mosdepth: loosen compiler pointer checks #391543

merged 1 commit into from
Mar 24, 2025

Conversation

ehmry
Copy link
Contributor

@ehmry ehmry commented Mar 20, 2025

  • pass -Wno-incompatible-pointer-types to the C compiler
  • replace testers.testVersion with versionCheckHook
  • add myself to maintainers

Reported in #391298.
Possibly related to #388196.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

- pass -Wno-incompatible-pointer-types to the C compiler
- replace testers.testVersion with versionCheckHook
- add myself to maintainers
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1 10.rebuild-linux: 1-10 labels Mar 20, 2025
@nix-owners nix-owners bot requested a review from jbedo March 20, 2025 11:49
@jbedo jbedo merged commit 076b4d9 into NixOS:master Mar 24, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants