Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

luanti: fix update script #391545

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

r-ryantm
Copy link
Contributor

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.

meta.description for luanti is: An open source voxel game engine (formerly Minetest)

meta.homepage for luanti is: https://www.luanti.org/

Updates performed
  • Ran passthru.UpdateScript
To inspect upstream changes
Impact

Checks done


  • built on NixOS
  • The tests defined in passthru.tests, if any, passed
  • found 5.11.0-rc1 in filename of file in /nix/store/ljq2jrr9ph2mjraq6zc9gqk4gkqp8rpm-luanti-5.11.0-rc1

Rebuild report (if merged into master) (click to expand)
4 total rebuild path(s)

4 package rebuild(s)

First fifty rebuilds by attrpath

luanti
luanti-client
luanti-server
Instructions to test this update (click to expand)

Either download from the cache:

nix-store -r /nix/store/ljq2jrr9ph2mjraq6zc9gqk4gkqp8rpm-luanti-5.11.0-rc1 \
  --option binary-caches 'https://cache.nixos.org/ https://nixpkgs-update-cache.nix-community.org/' \
  --option trusted-public-keys '
  nixpkgs-update-cache.nix-community.org-1:U8d6wiQecHUPJFSqHN9GSSmNkmdiFW7GW7WNAnHW0SM=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The nixpkgs-update cache is only trusted for this store-path realization.)
For the cached download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A luanti https://github.com/r-ryantm/nixpkgs/archive/18db4ef0cfab063f8585037eb9efc106fa4c5491.tar.gz

Or:

nix build github:r-ryantm/nixpkgs/18db4ef0cfab063f8585037eb9efc106fa4c5491#luanti

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/ljq2jrr9ph2mjraq6zc9gqk4gkqp8rpm-luanti-5.11.0-rc1
ls -la /nix/store/ljq2jrr9ph2mjraq6zc9gqk4gkqp8rpm-luanti-5.11.0-rc1/bin


Pre-merge build results

We have automatically built all packages that will get rebuilt due to
this change.

This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review


x86_64-linux

✅ 3 packages built:
  • luanti
  • luanti-client
  • luanti-server

Maintainer pings

cc @fpletz @fgaz @06kellyjac for testing.

Tip

As a maintainer, if your package is located under pkgs/by-name/*, you can comment @NixOS/nixpkgs-merge-bot merge to automatically merge this update using the nixpkgs-merge-bot.


Add a 👍 reaction to pull requests you find important.

@06kellyjac
Copy link
Member

Do not close please, this is the 5th PR raised, if you can just draft it until this is resolved.

@ryantm sorry for the ping (I pinged the wrong account last time 🤦), but is there anything we're doing wrong that's causing the bot to pick up release candidates?
There have been quite a few PRs created around this 5.11.0-rc1, I was hoping after merging the 5.11.0 release it'd stop.
It seems like 5.11.0-rc1 is properly labeled as pre-release too.

Could it be because the repo has now moved from minetest/minetest to luanti-org/luanti and the original repo gets a redirect?

@wegank wegank marked this pull request as draft March 20, 2025 13:18
@wegank wegank force-pushed the auto-update/luanti branch from 18db4ef to 2d9361f Compare March 20, 2025 13:25
@wegank wegank changed the title luanti: 5.11.0 -> 5.11.0-rc1 luanti: fix update script Mar 20, 2025
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux and removed 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Mar 20, 2025
@06kellyjac
Copy link
Member

Ah thanks @wegank 🙏
Is the update script even necessary or best to leave empty now for tools like nixpkgs-update and nix-update?

@wegank
Copy link
Member

wegank commented Mar 20, 2025

I'm not sure how nixpkgs-update works, so I'll leave that question to @ryantm...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants