Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gramps: 5.2.4 -> 6.0.0 #391563

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

gramps: 5.2.4 -> 6.0.0 #391563

wants to merge 1 commit into from

Conversation

TomaSajt
Copy link
Contributor

https://github.com/gramps-project/gramps/releases

Added orjson python package as a new dependency.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Copy link
Member

@06kellyjac 06kellyjac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment but otherwise looks good.
I'll try run this with a PR with an existing project when I get a moment

pname = "gramps";
pyproject = true;

disabled = pythonOlder "3.8";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this removed?
Wouldn't we want to keep this with 3.9 based on setup.py?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed it as it is only really useful if it's in the range of python versions provided by nixpkgs (3.9-3.13)

Also, this is not a python package, but a python app: it will only evaluated with the current python3Packages set.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, good to know.

I have had a play with building gramps as a python package too for the gramps web stuff but it's not quite there yet.

Copy link
Member

@06kellyjac 06kellyjac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Import worked fine.
Should probably have a release note item though

@TomaSajt
Copy link
Contributor Author

Import worked fine. Should probably have a release note item though

I'm not sure what release note item you're talking about, could you clarify?

@06kellyjac
Copy link
Member

From the PR template under "Things Done" above

25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)

  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module

Since this is a major version bump (5 -> 6) we should add a note in nixos/doc/manual/release-notes/rl-2505.section.md that people should backup first and outline any breaking changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants