-
-
Notifications
You must be signed in to change notification settings - Fork 15.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gramps: 5.2.4 -> 6.0.0 #391563
base: master
Are you sure you want to change the base?
gramps: 5.2.4 -> 6.0.0 #391563
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment but otherwise looks good.
I'll try run this with a PR with an existing project when I get a moment
pname = "gramps"; | ||
pyproject = true; | ||
|
||
disabled = pythonOlder "3.8"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this removed?
Wouldn't we want to keep this with 3.9
based on setup.py
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed it as it is only really useful if it's in the range of python versions provided by nixpkgs (3.9-3.13)
Also, this is not a python package, but a python app: it will only evaluated with the current python3Packages set.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, good to know.
I have had a play with building gramps as a python package too for the gramps web stuff but it's not quite there yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Import worked fine.
Should probably have a release note item though
I'm not sure what release note item you're talking about, could you clarify? |
From the PR template under "Things Done" above
Since this is a major version bump (5 -> 6) we should add a note in |
https://github.com/gramps-project/gramps/releases
Added
orjson
python package as a new dependency.Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.