Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

umu-launcher{-unwrapped}: 1.2.5 -> 1.2.6; add update script #391570

Merged
merged 2 commits into from
Mar 20, 2025

Conversation

MattSturgeon
Copy link
Contributor

@MattSturgeon MattSturgeon commented Mar 20, 2025

  • Added passthru.updateScript
  • Bumped version to 1.2.6
  • See Changelog

The update script can be used by the maintainers/scripts/update.nix script:

# Attempt to update a specific package:
nix-shell ./maintainers/scripts/update.nix --argstr package umu-launcher-unwrapped

# Or all packaged you maintain:
nix-shell ./maintainers/scripts/update.nix --argstr maintainer MattSturgeon

This should bump version to the latest released tag, and update the src and cargoDeps hashes. See Automatic package updates in the ./pkgs readme.

cc maintainers: @diniamo @LovingMelody

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Mar 20, 2025
@MattSturgeon
Copy link
Contributor Author

@diniamo @LovingMelody I noticed I can't request review from either of you, meaning you haven't joined the @NixOS org (see RFC39).

AFAIK you should've automatically been invited when you were added to the maintainers list.

@MattSturgeon MattSturgeon added 8.has: package (update) This PR updates a package to a newer version 11.by: package-maintainer This PR was created by the maintainer of the package it changes labels Mar 20, 2025
@khaneliman
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 391570


x86_64-linux

✅ 3 packages built:
  • heroic
  • umu-launcher
  • umu-launcher-unwrapped

aarch64-linux

✅ 2 packages built:
  • umu-launcher
  • umu-launcher-unwrapped

Copy link
Contributor

@khaneliman khaneliman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@diniamo
Copy link
Contributor

diniamo commented Mar 20, 2025

@diniamo @LovingMelody I noticed I can't request review from either of you, meaning you haven't joined the @NixOS org (see RFC39).

AFAIK you should've automatically been invited when you were added to the maintainers list.

I got the email long ago, and I forgot to accept it in time, so it expired. No idea how to get a new invite. IIRC I've tried asking on Matrix, but no one replied.

Copy link
Contributor

@diniamo diniamo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. One thing to note is that upstream has changed a lot of dependencies over the last few releases, and if that keeps being the case, an update script will be more annoying then helpful. Thought I doubt it will.

@MattSturgeon
Copy link
Contributor Author

if that keeps being the case, an update script will be more annoying then helpful.

The update script just bumps versions and hashes. You'll need to do this anyway regardless of whatever other changes are needed.

@MattSturgeon MattSturgeon added 12.approvals: 3+ This PR was reviewed and approved by three or more reputable people 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Mar 20, 2025
@khaneliman khaneliman merged commit e692c8a into NixOS:master Mar 20, 2025
45 checks passed
@MattSturgeon MattSturgeon deleted the umu/1.2.6 branch March 20, 2025 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: package (update) This PR updates a package to a newer version 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 3+ This PR was reviewed and approved by three or more reputable people 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants