-
-
Notifications
You must be signed in to change notification settings - Fork 15.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
umu-launcher{-unwrapped}: 1.2.5 -> 1.2.6; add update script #391570
Conversation
@diniamo @LovingMelody I noticed I can't request review from either of you, meaning you haven't joined the @NixOS org (see RFC39). AFAIK you should've automatically been invited when you were added to the maintainers list. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I got the email long ago, and I forgot to accept it in time, so it expired. No idea how to get a new invite. IIRC I've tried asking on Matrix, but no one replied. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. One thing to note is that upstream has changed a lot of dependencies over the last few releases, and if that keeps being the case, an update script will be more annoying then helpful. Thought I doubt it will.
The update script just bumps versions and hashes. You'll need to do this anyway regardless of whatever other changes are needed. |
passthru.updateScript
The update script can be used by the maintainers/scripts/update.nix script:
This should bump
version
to the latest released tag, and update thesrc
andcargoDeps
hashes. See Automatic package updates in the./pkgs
readme.cc maintainers: @diniamo @LovingMelody
Things done
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.