Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git-of-theseus: init at 0-unstable-2023-02-13 #391587

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fzakaria
Copy link
Contributor

Very cool tool to make nice graph plots of Git repositories.

Who wants to try this on Nixpkgs ? :P

Here is a sample image I did on the llvm-project (took a few hours)
image

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

CC author: @erikbern

@fzakaria
Copy link
Contributor Author

I ran it locally on NixOS

> ./result/bin/git-of-theseus-analyze --help | head
usage: git-of-theseus-analyze [-h] [--cohortfm COHORTFM] [--interval INTERVAL]
                              [--ignore IGNORE] [--only ONLY]
                              [--outdir OUTDIR] [--branch BRANCH]
                              [--ignore-whitespace] [--all-filetypes]
                              [--quiet] [--procs PROCS] [--opt]
                              repo_dir

Analyze git repo

positional arguments:

@fzakaria fzakaria requested a review from toastal March 21, 2025 04:56
@toastal
Copy link
Contributor

toastal commented Mar 21, 2025

You will want to fix-up & reword the commits here via git rebase. Interactively you can:

$ git rebase -i HEAD~2

Will open the $EDITOR. Change

pick 5294d98663 git-of-theseus: init at 961bda0
pick 84bc34afd6 Update package.nix

to

reword 5294d98663 git-of-theseus: init at 961bda0
fixup  84bc34afd6 Update package.nix

Reset the commit message title to reflect the new version @ 0-unstable-2023-02-13 instead of the hash.

$ git rebase --continue

to fixup the initial commit with the new versions.

Then remove the with lib; & rec (if possible). Use git add -p to interactively check over your changes then git commit --amend to amend the original commit. When you are ready to go git push --force-with-lease origin git-of-theseus.

Since these are just fixups based on a review, they should not pollute the Git history.

@toastal
Copy link
Contributor

toastal commented Mar 21, 2025

Also the MS GitHub pull request title here should be updated to reflect the new version as well.

@toastal
Copy link
Contributor

toastal commented Mar 21, 2025

Additionally… you don’t need marketing text in PRs about why, but this is minor.

@fzakaria fzakaria changed the title git-of-theseus: init at 961bda0 git-of-theseus: init at 0-unstable-2023-02-13 Mar 21, 2025
@fzakaria fzakaria requested a review from toastal March 21, 2025 15:54
@fzakaria
Copy link
Contributor Author

@toastal thank you for the clear instructions;

I was kind of at first like "ugh" with all the feedback but at least you were very clear on what I had to do -- so it wasn't too bad 🙏

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Mar 21, 2025
@awwpotato
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 391587


x86_64-linux

✅ 2 packages built:
  • git-of-theseus
  • git-of-theseus.dist

@awwpotato
Copy link
Contributor

awwpotato commented Mar 23, 2025

The binaries aren't inside ./result/bin, is this intended? ignore, I was being dumb

@wegank wegank added 12.approvals: 2 This PR was reviewed and approved by two reputable people and removed 12.approvals: 1 This PR was reviewed and approved by one reputable person labels Mar 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants