Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pdm: use replace-fail #391601

Merged
merged 1 commit into from
Mar 21, 2025
Merged

pdm: use replace-fail #391601

merged 1 commit into from
Mar 21, 2025

Conversation

SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Mar 20, 2025 •
edited
Loading

because if it fails, we want to know

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@SuperSandro2000
pdm: use replace-fail
f802335 
because if it fails, we want to know
@nix-owners nix-owners bot requested review from MisileLab, natsukium and cpcloud March 20, 2025 16:24
@SuperSandro2000 SuperSandro2000 merged commit 6bf652d into NixOS:master Mar 21, 2025
42 of 43 checks passed
@SuperSandro2000 SuperSandro2000 deleted the pdm-fix branch March 21, 2025 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MisileLab MisileLab

@natsukium natsukium

@cpcloud cpcloud

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SuperSandro2000 @MisileLab