weylus: unstable-2022-06-07 -> 0.11.4-unstable-2025-02-24; modernize derivation; move to by-name #391603
Conversation
github-actions
bot
added
6.topic: nixos
ofborg
bot
added
the
2.status: merge conflict
ofborg
bot
removed
the
2.status: merge conflict
KSJ2000
force-pushed
the
weylus
branch
2 times, most recently
from
15b653f to
655cca7
Compare
github-actions
bot
added
10.rebuild-darwin: 0
nixos/modules/programs/weylus.nix
Outdated
| package = lib.mkOption { | ||
| type = package; | ||
| default = pkgs.callPackage ../../../pkgs/by-name/we/weylus/package.nix { }; | ||
| defaultText = lib.literalExpression "pkgs.callPackage ../../../pkgs/by-name/we/weylus/package.nix {}"; | ||
| description = '' | ||
| The weylus package to use. | ||
| ''; | ||
| }; | ||
| }; |
There was a problem hiding this comment.
Why was this change made?
There was a problem hiding this comment.
It gave some errors otherwise because of the change to by-name/package.nix
Tho I'm not sure if that's the best way to do it
There was a problem hiding this comment.
You are right. It was probably something transient that got resolved when I rebased.
| lib, | ||
| stdenv, | ||
| rustPlatform, | ||
| fetchFromGitHub, | ||
| makeWrapper, | ||
| autoconf, | ||
| cmake, | ||
| dbus, | ||
| fetchFromGitHub, | ||
| ffmpeg, | ||
| x264, | ||
| libva, | ||
| git, | ||
| gst_all_1, | ||
| xorg, | ||
| lib, | ||
| libdrm, | ||
| pkg-config, | ||
| libtool, | ||
| libva, | ||
| libxkbcommon, | ||
| makeWrapper, | ||
| nix-update-script, | ||
| pango, | ||
| pipewire, | ||
| cmake, | ||
| git, | ||
| autoconf, | ||
| libtool, | ||
| pkg-config, | ||
| rustPlatform, | ||
| typescript, | ||
| ApplicationServices, | ||
| Carbon, | ||
| Cocoa, | ||
| VideoToolbox, | ||
| libxkbcommon, |
There was a problem hiding this comment.
I get all this is now alphabetically ordered, but lib, stdenv are usually at the top.
| license = with lib.licenses; [ agpl3Only ]; | ||
| mainProgram = "weylus"; | ||
| maintainers = with lib.maintainers; [ lom ]; | ||
| platforms = lib.platforms.linux; |
There was a problem hiding this comment.
Did upstream drop support for darwin?
If no, I think we ought to keep broken = and all the lib.optionals stuff.
There was a problem hiding this comment.
If darwin doesn't work, is it better to have platforms=unix and broken=darwin instead of platforms linux? especially since there have been no more releases for like 4 years..
github-actions
bot
added
10.rebuild-linux: 1
and removed
6.topic: nixos
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.