-
-
Notifications
You must be signed in to change notification settings - Fork 15.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
television: 0.10.9 -> 0.11.2 #391606
television: 0.10.9 -> 0.11.2 #391606
Conversation
|
0.11.2 has been released Also note that 0.11 comes with breaking changes to the keybinds configuration, so you'll probably get an error like this
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feel free to bump. I'll merge in a couple days if not ;)
nixpkgs-review
result
Generated using nixpkgs-review
.
Command: nixpkgs-review pr 391606
x86_64-linux
✅ 1 package built:
- television
You're right. When a breaking change like this happens in the future, should I write something about it in the PR message ? |
f7ae283
to
80b31e7
Compare
Usually just posting the changelog and mentioning it has breaking change is fine IMO. I only explicitly explained what it was in this case because upstream kinda buried it, so it confused me for a good sec 😆 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nixpkgs-review
result
Generated using nixpkgs-review
.
Command: nixpkgs-review pr 391606
x86_64-linux
✅ 1 package built:
- television
aarch64-darwin
✅ 1 package built:
- television
Diff: https://github.com/alexpasmantier/television/compare/0.10.9..0.11.0
Changelog: alexpasmantier/television@0.11.0 (release)
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.