Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

television: 0.10.9 -> 0.11.2 #391606

Merged
merged 1 commit into from
Mar 21, 2025
Merged

television: 0.10.9 -> 0.11.2 #391606

merged 1 commit into from
Mar 21, 2025

Conversation

louis-thevenet
Copy link
Contributor

Diff: https://github.com/alexpasmantier/television/compare/0.10.9..0.11.0
Changelog: alexpasmantier/television@0.11.0 (release)

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ddogfoodd
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 391606


x86_64-linux

✅ 1 package built:
  • television

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Mar 21, 2025
@getchoo
Copy link
Member

getchoo commented Mar 21, 2025

0.11.2 has been released

Also note that 0.11 comes with breaking changes to the keybinds configuration, so you'll probably get an error like this

Caused by:
    TOML parse error at line 75, column 14
       |
    75 | [keybindings.Channel]
       |              ^^^^^^^
    unknown variant `Channel`, expected one of `GoToInputStart`, `go_to_input_start`, `GoToInputEnd`, `go_to_input_end`, `ToggleSelectionDown`, `toggle_selection_down`, `ToggleSelectionUp`, `toggle_selection_up`, `ConfirmSelection`, `confirm_selection`, `select_entry`, `SelectPassthrough`, `select_passthrough`, `SelectAndExit`, `select_and_exit`, `SelectNextEntry`, `select_next_entry`, `SelectPrevEntry`, `select_prev_entry`, `SelectNextPage`, `select_next_page`, `SelectPrevPage`, `select_prev_page`, `CopyEntryToClipboard`, `copy_entry_to_clipboard`, `ScrollPreviewUp`, `scroll_preview_up`, `ScrollPreviewDown`, `scroll_preview_down`, `ScrollPreviewHalfPageUp`, `scroll_preview_half_page_up`, `ScrollPreviewHalfPageDown`, `scroll_preview_half_page_down`, `Quit`, `quit`, `ToggleHelp`, `toggle_help`, `TogglePreview`, `toggle_preview`, `ToggleRemoteControl`, `toggle_remote_control`, `ToggleSendToChannel`, `toggle_send_to_channel`

See alexpasmantier/television#404

Copy link
Member

@getchoo getchoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to bump. I'll merge in a couple days if not ;)

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 391606


x86_64-linux

✅ 1 package built:
  • television

@getchoo getchoo added 12.approvals: 2 This PR was reviewed and approved by two reputable people 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package and removed 12.approvals: 1 This PR was reviewed and approved by one reputable person labels Mar 21, 2025
@louis-thevenet
Copy link
Contributor Author

Also note that 0.11 comes with breaking changes to the keybinds configuration, so you'll probably get an error like this

You're right. When a breaking change like this happens in the future, should I write something about it in the PR message ?

@louis-thevenet louis-thevenet changed the title television: 0.10.9 -> 0.11.0 television: 0.10.9 -> 0.11.2 Mar 21, 2025
@louis-thevenet louis-thevenet requested a review from getchoo March 21, 2025 20:09
@getchoo
Copy link
Member

getchoo commented Mar 21, 2025

When a breaking change like this happens in the future, should I write something about it in the PR message ?

Usually just posting the changelog and mentioning it has breaking change is fine IMO. I only explicitly explained what it was in this case because upstream kinda buried it, so it confused me for a good sec 😆

image

Copy link
Member

@getchoo getchoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 391606


x86_64-linux

✅ 1 package built:
  • television

aarch64-darwin

✅ 1 package built:
  • television

@getchoo getchoo added 12.approvals: 1 This PR was reviewed and approved by one reputable person and removed 12.approvals: 2 This PR was reviewed and approved by two reputable people labels Mar 21, 2025
@getchoo getchoo merged commit 29a00f9 into NixOS:master Mar 21, 2025
32 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants