Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ants: add coreutils to PATH #391624

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

ants: add coreutils to PATH #391624

wants to merge 1 commit into from

Conversation

bcdarwin
Copy link
Member

@bcdarwin bcdarwin commented Mar 20, 2025

Fixes #391554.

Possibly a bit overkill to add coreutils to every executable's path, but certainly the simplest approach.

@sceptri

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

In this way coreutils is not removed from PATH.

Fixes NixOS#391554
@isabelroses isabelroses added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Mar 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ANTs: .sh commands do not work
2 participants