-
-
Notifications
You must be signed in to change notification settings - Fork 15.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nixos/doc: Fix outdated references in the NixOS manual #391626
nixos/doc: Fix outdated references in the NixOS manual #391626
Conversation
hello @fricklerhandwerk please could you review this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello!
Congratulations for your first PR !
I added a minor comment, also, make sure to format the PR title according to the user contributor guide, the commit messages should also be reworked accordingly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The commit log messages of your commits are not really formatted correctly and must be updated. Have you checked the contributing guide? Have a look at other PR to get some inspiration. Thanks.
Hi @drupol I have gone through the commit convention. when you say "commits are not really formatted" do you mean i should remove whitespaces? |
nixpkgs
Outdated
@@ -0,0 +1 @@ | |||
Subproject commit b64ec1944ea40d9f3920f938e17ed39a9978c6c7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to be an editing artifact that needs to go away.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fricklerhandwerk Fixed! I removed the unintended submodule change. Thanks for catching that! Let me know if anything else needs adjustment
827f750
to
fbbd029
Compare
fbbd029
to
e5da5c5
Compare
Thanks for the feedback @drupol I've updated the commit messages to follow the correct format. Please have a look at it and let me know if any further adjustments are needed. |
Have a look at this PR to get some inspiration: #392831 |
e5da5c5
to
0f177ec
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks !
Fixed outdated references in the NixOS Manual
The previous manual contained outdated references to 'make' and incorrect shell prompts.
This commit updates the formatting to improve readability and ensure accuracy.
Fixes:
Fixed outdated references from
make
todevmode
, corrected shell prompts fromnix-shell$
to[nix-shell:~]$
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.